chore(deps): bump typescript to 4.8.4 (apache#24272)

Co-authored-by: Ville Brofeldt <[email protected]>
preset-io · Jan 31, 2024 · fddc618 · fddc618
1 parent d27fade
commit fddc618
Show file tree

Hide file tree

Showing 10 changed files with 30 additions and 15 deletions.
diff --git a/superset-frontend/package-lock.json b/superset-frontend/package-lock.json
diff --git a/superset-frontend/package.json b/superset-frontend/package.json
@@ -335,7 +335,7 @@
     "thread-loader": "^3.0.4",
     "transform-loader": "^0.2.4",
     "ts-loader": "^9.4.4",
-    "typescript": "^4.5.4",
+    "typescript": "^4.8.4",
     "vm-browserify": "^1.1.2",
     "webpack": "^5.88.1",
     "webpack-bundle-analyzer": "^4.9.0",

diff --git a/superset-frontend/packages/superset-ui-core/src/chart/components/createLoadableRenderer.ts b/superset-frontend/packages/superset-ui-core/src/chart/components/createLoadableRenderer.ts
@@ -33,9 +33,10 @@ export interface LoadableRenderer<Props>
   extends React.ComponentClass<Props & LoadableRendererProps>,
     Loadable.LoadableComponent {}
 
-export default function createLoadableRenderer<Props, Exports>(
-  options: Loadable.OptionsWithMap<Props, Exports>,
-): LoadableRenderer<Props> {
+export default function createLoadableRenderer<
+  Props,
+  Exports extends { [key: string]: any },
+>(options: Loadable.OptionsWithMap<Props, Exports>): LoadableRenderer<Props> {
   const LoadableRenderer = Loadable.Map(options) as LoadableRenderer<Props>;
 
   // Extends the behavior of LoadableComponent to provide post-render listeners

diff --git a/superset-frontend/packages/superset-ui-core/src/query/api/v1/makeApi.ts b/superset-frontend/packages/superset-ui-core/src/query/api/v1/makeApi.ts
@@ -112,13 +112,13 @@ export default function makeApi<
         endpoint,
       };
       if (requestType === 'search') {
-        requestConfig.searchParams = payload;
+        requestConfig.searchParams = payload as SupersetPayload;
       } else if (requestType === 'rison') {
         requestConfig.endpoint = `${endpoint}?q=${rison.encode(payload)}`;
       } else if (requestType === 'form') {
-        requestConfig.postPayload = payload;
+        requestConfig.postPayload = payload as SupersetPayload;
       } else {
-        requestConfig.jsonPayload = payload;
+        requestConfig.jsonPayload = payload as SupersetPayload;
       }
 
       let result: JsonValue | Response;

diff --git a/superset-frontend/packages/superset-ui-switchboard/src/switchboard.ts b/superset-frontend/packages/superset-ui-switchboard/src/switchboard.ts
@@ -175,7 +175,10 @@ export class Switchboard {
   /**
    * Defines a method that can be "called" from the other side by sending an event.
    */
-  defineMethod<A = any, R = any>(methodName: string, executor: Method<A, R>) {
+  defineMethod<A extends {} = any, R = any>(
+    methodName: string,
+    executor: Method<A, R>,
+  ) {
     this.methods[methodName] = executor;
   }
 

diff --git a/superset-frontend/plugins/plugin-chart-table/src/DataTable/hooks/useSticky.tsx b/superset-frontend/plugins/plugin-chart-table/src/DataTable/hooks/useSticky.tsx
@@ -350,6 +350,7 @@ function useInstance<D extends object>(instance: TableInstance<D>) {
   );
 
   const useStickyWrap = (renderer: TableRenderer) => {
+    // @ts-ignore
     const { width, height } =
       useMountedMemo(getTableSize, [getTableSize]) || sticky;
     // only change of data should trigger re-render

diff --git a/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx b/superset-frontend/plugins/plugin-chart-table/src/controlPanel.tsx
@@ -189,7 +189,7 @@ const config: ControlPanelConfig = {
           },
         ],
         [
-          hasGenericChartAxes && isAggMode
+          hasGenericChartAxes
             ? {
                 name: 'time_grain_sqla',
                 config: {
@@ -217,7 +217,7 @@ const config: ControlPanelConfig = {
                 },
               }
             : null,
-          hasGenericChartAxes && isAggMode ? 'temporal_columns_lookup' : null,
+          hasGenericChartAxes ? 'temporal_columns_lookup' : null,
         ],
         [
           {

diff --git a/superset-frontend/plugins/plugin-chart-table/src/utils/extent.ts b/superset-frontend/plugins/plugin-chart-table/src/utils/extent.ts
@@ -16,6 +16,9 @@
  * specific language governing permissions and limitations
  * under the License.
  */
+
+import { isNil } from 'lodash';
+
 export default function extent<T = number | string | Date | undefined | null>(
   values: T[],
 ) {
@@ -24,16 +27,16 @@ export default function extent<T = number | string | Date | undefined | null>(
   // eslint-disable-next-line no-restricted-syntax
   for (const value of values) {
     if (value !== null) {
-      if (min === undefined) {
+      if (isNil(min)) {
         if (value !== undefined) {
           min = value;
           max = value;
         }
-      } else {
+      } else if (value !== undefined) {
         if (min > value) {
           min = value;
         }
-        if (max !== undefined) {
+        if (!isNil(max)) {
           if (max < value) {
             max = value;
           }

diff --git a/superset-frontend/plugins/plugin-chart-word-cloud/src/chart/WordCloud.tsx b/superset-frontend/plugins/plugin-chart-word-cloud/src/chart/WordCloud.tsx
@@ -158,6 +158,7 @@ class WordCloud extends React.PureComponent<
   update() {
     const { data, encoding } = this.props;
 
+    // @ts-ignore
     const encoder = this.createEncoder(encoding);
     encoder.setDomainFromDataset(data);
 
@@ -221,6 +222,7 @@ class WordCloud extends React.PureComponent<
     const { width, height, encoding, sliceId } = this.props;
     const { words } = this.state;
 
+    // @ts-ignore
     const encoder = this.createEncoder(encoding);
     encoder.channels.color.setDomainFromDataset(words);
 

diff --git a/superset-frontend/src/components/Modal/Modal.tsx b/superset-frontend/src/components/Modal/Modal.tsx
@@ -261,6 +261,7 @@ const CustomModal = ({
   if (React.isValidElement(footer)) {
     // If a footer component is provided inject a closeModal function
     // so the footer can provide a "close" button if desired
+    // @ts-ignore
     FooterComponent = React.cloneElement(footer, { closeModal: onHide });
   }
   const modalFooter = isNil(FooterComponent)