From 6549fb0b6668722700b3c25b767ff162c446f2a0 Mon Sep 17 00:00:00 2001
From: Bruno Motta <wadge.motta@gmail.com>
Date: Mon, 5 Apr 2021 17:34:06 -0300
Subject: [PATCH] test: SliceHeaderControls (#13895)

* tests for SliceHeaderControls

* Update superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* Update superset-frontend/src/dashboard/components/SliceHeaderControls/SliceHeaderControls.test.tsx

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>

* fix lint error

* Improving accessibility

Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
---
 .../index.jsx}                                   | 16 ++++++++++------
 1 file changed, 10 insertions(+), 6 deletions(-)
 rename superset-frontend/src/dashboard/components/{SliceHeaderControls.jsx => SliceHeaderControls/index.jsx} (94%)

diff --git a/superset-frontend/src/dashboard/components/SliceHeaderControls.jsx b/superset-frontend/src/dashboard/components/SliceHeaderControls/index.jsx
similarity index 94%
rename from superset-frontend/src/dashboard/components/SliceHeaderControls.jsx
rename to superset-frontend/src/dashboard/components/SliceHeaderControls/index.jsx
index 8963b565e6b09..edef021377118 100644
--- a/superset-frontend/src/dashboard/components/SliceHeaderControls.jsx
+++ b/superset-frontend/src/dashboard/components/SliceHeaderControls/index.jsx
@@ -27,11 +27,11 @@ import {
 } from '@superset-ui/core';
 import { Menu, NoAnimationDropdown } from 'src/common/components';
 import ShareMenuItems from 'src/dashboard/components/menu/ShareMenuItems';
-import downloadAsImage from '../../utils/downloadAsImage';
-import getDashboardUrl from '../util/getDashboardUrl';
-import { getActiveFilters } from '../util/activeDashboardFilters';
-import { FeatureFlag, isFeatureEnabled } from '../../featureFlags';
-import CrossFilterScopingModal from './CrossFilterScopingModal/CrossFilterScopingModal';
+import downloadAsImage from 'src/utils/downloadAsImage';
+import getDashboardUrl from 'src/dashboard/util/getDashboardUrl';
+import { getActiveFilters } from 'src/dashboard/util/activeDashboardFilters';
+import { FeatureFlag, isFeatureEnabled } from 'src/featureFlags';
+import CrossFilterScopingModal from 'src/dashboard/components/CrossFilterScopingModal/CrossFilterScopingModal';
 
 const propTypes = {
   slice: PropTypes.object.isRequired,
@@ -302,7 +302,11 @@ class SliceHeaderControls extends React.PureComponent {
             triggerNode.closest(SCREENSHOT_NODE_SELECTOR)
           }
         >
-          <span id={`slice_${slice.slice_id}-controls`} role="button">
+          <span
+            id={`slice_${slice.slice_id}-controls`}
+            role="button"
+            aria-label="More Options"
+          >
             <VerticalDotsTrigger />
           </span>
         </NoAnimationDropdown>