-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: checksums for all manifest download urls #423
Comments
I would start doing the following @swarnimarun
BONUS Let's take the occasion to introduce a https://json-schema.org so we can maintain easily the manifest |
for OSS services we control, I very very strongly suggest using URLs with built-in checksums instead, e.g. https://github.com/premAI-io/prem-services/releases/download/v1/cht-llama-cpp-mistral-1.1.2-aarch64-apple-darwin instead of https://github.com/premAI-io/prem-services/releases/download/v1/cht-llama-cpp-mistral-1-aarch64-apple-darwin becuase
For external URLs, sure we can have an (optional) checksum field. |
Feature/Goal
Provide checksums in manifests for all downloadable urls.
Eg,
And verify against the checksum the existing or downloaded binary for ensuring correct version is present or that we haven't downloaded the wrong binary.
Motivation
Currently we don't verify the downloaded artifacts to be the correct version or same as the expected binary in general. This can cause a few issues,
The locally present binary doesn't match what the manifest requests even if the binary names are the same.
Possibly the binary downloaded from the url has been changed/updated and there is a mismatch in version downloaded and version tested when making the service manifest.
Or, the url now points to a malicious binary due to any reason, which we won't want to be allowed to be executed.
FAQ
Who is in-charge to make the checksum? The service developer or internal github action in registry?
Do we plan to provide tools for automating this process?
But we haven't finalized it internally yet.
Do we want to be relaxed and still download services without checksum, simply showing in UI as “dangerous” because not verified?
Does this apply to all download urls?
The text was updated successfully, but these errors were encountered: