Packaging excludes .pyc files if there is no corresponding .py file

[mwiebe]

We've got a case where we are building packages that incorporate third party .pyc files that are not shipped with the .py files they came from. Rattler-build is excluding these files from the package due to the code in

rattler-build/src/packaging/file_mapper.rs

Line 17 in 31a1e44

pub fn filter_pyc(path: &Path, new_files: &HashSet<PathBuf>) -> bool {

/// We check that each `pyc` file in the package is also present as a `py` file.
/// This is a temporary measure to avoid packaging `pyc` files that are not
/// generated by the build process.
pub fn filter_pyc(path: &Path, new_files: &HashSet<PathBuf>) -> bool {
...

In this case the .pyc files that lack their .py file are intentional, so we do not want them excluded. Is it reasonable to switch this logic?

For a workaround, we've implemented our recipes to rename all .pyc files to .pyc2, something like:

for PYC in "$PREFIX/.../*.pyc; do
    mv "$PYC" "${PYC}2"
done

and then in an environment activation script, rename those back to .pyc:

if [ -f \$CONDA_PREFIX/.../known_module.pyc2 ]; then
    for PYC2 in "\$CONDA_PREFIX/.../*.pyc2; do
        mv "\$PYC2" "\${PYC2%2}"
    done
fi

[wolfv]

Hi @mwiebe - thanks for the detailed bug report! I think we can adjust the logic to ignore only .pyc files where a previously installed package had a .py file.

[wolfv]

Fixed in #1246 and added a test. Going to be released tomorrow if things go right! :)