-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: also glob folders under files:
without trailing backslash
#1055
Comments
Thoughts @wolfv? |
I want to double check with some other tools before making a decision. I really think explicit >> implicit :) |
I agree on that principle, but it's a pointless distinction here IMO. You cannot have a file |
Since both github actions and |
No question that you can support the trailing backslash. My point is that you should not gratuitously introduce breaking changes. If you feel strongly about changing behaviour from what conda-build is doing, then warn/deprecate and eventually remove. But every single behavioural difference will make the v1 migration a pain. IMO you should start out as compatible as possible; though of course that doesn't mean though that you cannot change behaviour over time. Clearly there are cases where behaviour changes are justified, from the POV of semantics, architecture or even just sanity. But enforcing trailing backslashes on folders is hardly worth the migration pain this will cause because suddenly packages don't contain what they were expected to (and you have no way for the recipe manager to know whether a given path without trailing backslash is a file or a folder, so you cannot even catch it during translation). |
Currently, rattler-build will -- in contrast to conda-build -- fail to pick up
$PREFIX/include/...
when doingbut will pick it up if there's a trailing backslash, i.e.
- include/
. In #1051 we discussed:IMO rattler-build should match conda-build here. It could additionally warn on a missing backslash if it matches a folder, but given that even
ls
makes no distinction there, this added strictness is IMO a net negative.The text was updated successfully, but these errors were encountered: