From 49172dd5be1a69ba0e8e27f6e814e26763c75632 Mon Sep 17 00:00:00 2001 From: Mehdi Rahimi Date: Mon, 13 Jan 2025 19:33:54 +0330 Subject: [PATCH 1/4] fix: Minor misspelling (#3161) --- localization/es/strategy/README.md | 2 +- localization/ko/strategy/README.md | 2 +- strategy/README.md | 6 +++--- strategy/src/main/java/com/iluwatar/strategy/App.java | 2 +- .../src/main/java/com/iluwatar/strategy/LambdaStrategy.java | 2 +- 5 files changed, 7 insertions(+), 7 deletions(-) diff --git a/localization/es/strategy/README.md b/localization/es/strategy/README.md index 5c04764f4c2d..d211914458e2 100644 --- a/localization/es/strategy/README.md +++ b/localization/es/strategy/README.md @@ -127,7 +127,7 @@ public class LambdaStrategy { public enum Strategy implements DragonSlayingStrategy { MeleeStrategy(() -> LOGGER.info( - "With your Excalibur you severe the dragon's head!")), + "With your Excalibur you sever the dragon's head!")), ProjectileStrategy(() -> LOGGER.info( "You shoot the dragon with the magical crossbow and it falls dead on the ground!")), SpellStrategy(() -> LOGGER.info( diff --git a/localization/ko/strategy/README.md b/localization/ko/strategy/README.md index e445fa91d3d2..f604962d1f6b 100644 --- a/localization/ko/strategy/README.md +++ b/localization/ko/strategy/README.md @@ -123,7 +123,7 @@ public class LambdaStrategy { public enum Strategy implements DragonSlayingStrategy { MeleeStrategy(() -> LOGGER.info( - "With your Excalibur you severe the dragon's head!")), + "With your Excalibur you sever the dragon's head!")), ProjectileStrategy(() -> LOGGER.info( "You shoot the dragon with the magical crossbow and it falls dead on the ground!")), SpellStrategy(() -> LOGGER.info( diff --git a/strategy/README.md b/strategy/README.md index 08004ad25a1c..781463d20af8 100644 --- a/strategy/README.md +++ b/strategy/README.md @@ -127,7 +127,7 @@ public class App { // Java 8 functional implementation Strategy pattern LOGGER.info(GREEN_DRAGON_SPOTTED); dragonSlayer = new DragonSlayer( - () -> LOGGER.info("With your Excalibur you severe the dragon's head!")); + () -> LOGGER.info("With your Excalibur you sever the dragon's head!")); dragonSlayer.goToBattle(); LOGGER.info(RED_DRAGON_EMERGES); dragonSlayer.changeStrategy(() -> LOGGER.info( @@ -162,13 +162,13 @@ Program output: 13:06:36.634 [main] INFO com.iluwatar.strategy.App -- Black dragon lands before you. 13:06:36.634 [main] INFO com.iluwatar.strategy.SpellStrategy -- You cast the spell of disintegration and the dragon vaporizes in a pile of dust! 13:06:36.634 [main] INFO com.iluwatar.strategy.App -- Green dragon spotted ahead! -13:06:36.634 [main] INFO com.iluwatar.strategy.App -- With your Excalibur you severe the dragon's head! +13:06:36.634 [main] INFO com.iluwatar.strategy.App -- With your Excalibur you sever the dragon's head! 13:06:36.634 [main] INFO com.iluwatar.strategy.App -- Red dragon emerges. 13:06:36.635 [main] INFO com.iluwatar.strategy.App -- You shoot the dragon with the magical crossbow and it falls dead on the ground! 13:06:36.635 [main] INFO com.iluwatar.strategy.App -- Black dragon lands before you. 13:06:36.635 [main] INFO com.iluwatar.strategy.App -- You cast the spell of disintegration and the dragon vaporizes in a pile of dust! 13:06:36.635 [main] INFO com.iluwatar.strategy.App -- Green dragon spotted ahead! -13:06:36.637 [main] INFO com.iluwatar.strategy.LambdaStrategy -- With your Excalibur you severe the dragon's head! +13:06:36.637 [main] INFO com.iluwatar.strategy.LambdaStrategy -- With your Excalibur you sever the dragon's head! 13:06:36.637 [main] INFO com.iluwatar.strategy.App -- Red dragon emerges. 13:06:36.637 [main] INFO com.iluwatar.strategy.LambdaStrategy -- You shoot the dragon with the magical crossbow and it falls dead on the ground! 13:06:36.637 [main] INFO com.iluwatar.strategy.App -- Black dragon lands before you. diff --git a/strategy/src/main/java/com/iluwatar/strategy/App.java b/strategy/src/main/java/com/iluwatar/strategy/App.java index aa603c1065ed..28cb88dfb39b 100644 --- a/strategy/src/main/java/com/iluwatar/strategy/App.java +++ b/strategy/src/main/java/com/iluwatar/strategy/App.java @@ -66,7 +66,7 @@ public static void main(String[] args) { // Java 8 functional implementation Strategy pattern LOGGER.info(GREEN_DRAGON_SPOTTED); dragonSlayer = new DragonSlayer( - () -> LOGGER.info("With your Excalibur you severe the dragon's head!")); + () -> LOGGER.info("With your Excalibur you sever the dragon's head!")); dragonSlayer.goToBattle(); LOGGER.info(RED_DRAGON_EMERGES); dragonSlayer.changeStrategy(() -> LOGGER.info( diff --git a/strategy/src/main/java/com/iluwatar/strategy/LambdaStrategy.java b/strategy/src/main/java/com/iluwatar/strategy/LambdaStrategy.java index e31621db0ea3..da9b76a84d98 100644 --- a/strategy/src/main/java/com/iluwatar/strategy/LambdaStrategy.java +++ b/strategy/src/main/java/com/iluwatar/strategy/LambdaStrategy.java @@ -37,7 +37,7 @@ public class LambdaStrategy { */ public enum Strategy implements DragonSlayingStrategy { MELEE_STRATEGY(() -> LOGGER.info( - "With your Excalibur you severe the dragon's head!")), + "With your Excalibur you sever the dragon's head!")), PROJECTILE_STRATEGY(() -> LOGGER.info( "You shoot the dragon with the magical crossbow and it falls dead on the ground!")), SPELL_STRATEGY(() -> LOGGER.info( From 07c82e460a8357fc4252f9c9040ce18e576bf2fb Mon Sep 17 00:00:00 2001 From: "allcontributors[bot]" <46447321+allcontributors[bot]@users.noreply.github.com> Date: Mon, 13 Jan 2025 18:04:49 +0200 Subject: [PATCH 2/4] docs: add mehdirahimi as a contributor for code (#3175) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> --- .all-contributorsrc | 9 +++++++++ README.md | 3 ++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/.all-contributorsrc b/.all-contributorsrc index a2076f489ab2..c86f6bc4f31f 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -3366,6 +3366,15 @@ "contributions": [ "code" ] + }, + { + "login": "mehdirahimi", + "name": "Mehdi Rahimi", + "avatar_url": "https://avatars.githubusercontent.com/u/24210842?v=4", + "profile": "https://mehdirahimi.github.io", + "contributions": [ + "code" + ] } ], "contributorsPerLine": 6, diff --git a/README.md b/README.md index ddf0f865b129..2d5ca9bfa104 100644 --- a/README.md +++ b/README.md @@ -6,7 +6,7 @@ [![Coverage](https://sonarcloud.io/api/project_badges/measure?project=iluwatar_java-design-patterns&metric=coverage)](https://sonarcloud.io/dashboard?id=iluwatar_java-design-patterns) [![Join the chat at https://gitter.im/iluwatar/java-design-patterns](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/iluwatar/java-design-patterns?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge) -[![All Contributors](https://img.shields.io/badge/all_contributors-369-orange.svg?style=flat-square)](#contributors-) +[![All Contributors](https://img.shields.io/badge/all_contributors-370-orange.svg?style=flat-square)](#contributors-)
@@ -552,6 +552,7 @@ This project is licensed under the terms of the MIT license. BiKangNing
BiKangNing
📖 Tarun Vishwakarma
Tarun Vishwakarma
💻 Shahd Hossam
Shahd Hossam
💻 + Mehdi Rahimi
Mehdi Rahimi
💻 From 2a261cd7340990e062e8dca8281db90cc4ffa5ff Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Clint=20Air=C3=A9?= <111376518+clintaire@users.noreply.github.com> Date: Mon, 13 Jan 2025 19:05:51 +0000 Subject: [PATCH 3/4] chore: Remove obsolete update-header.sh (#3174) * chore: add MIT license information to update-header.sh * chore: remove update-header.sh script --- update-header.sh | 7 ------- 1 file changed, 7 deletions(-) delete mode 100755 update-header.sh diff --git a/update-header.sh b/update-header.sh deleted file mode 100755 index 48da4dcd6125..000000000000 --- a/update-header.sh +++ /dev/null @@ -1,7 +0,0 @@ -#!/bin/bash - -# Find all README.md files in subdirectories one level deep -# and replace "### " with "## " at the beginning of lines -find . -maxdepth 2 -type f -name "README.md" -exec sed -i '' 's/^### /## /' {} \; - -echo "Headers updated in README.md files." From 3a1a71405bd2d78ba3e0dffcaa9f84b632259bae Mon Sep 17 00:00:00 2001 From: "allcontributors[bot]" <46447321+allcontributors[bot]@users.noreply.github.com> Date: Mon, 13 Jan 2025 21:06:39 +0200 Subject: [PATCH 4/4] docs: add clintaire as a contributor for code (#3176) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] --------- Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> --- .all-contributorsrc | 9 +++++++++ README.md | 3 ++- 2 files changed, 11 insertions(+), 1 deletion(-) diff --git a/.all-contributorsrc b/.all-contributorsrc index c86f6bc4f31f..801b57171e02 100644 --- a/.all-contributorsrc +++ b/.all-contributorsrc @@ -3375,6 +3375,15 @@ "contributions": [ "code" ] + }, + { + "login": "clintaire", + "name": "Clint Airé", + "avatar_url": "https://avatars.githubusercontent.com/u/111376518?v=4", + "profile": "https://github.com/clintaire", + "contributions": [ + "code" + ] } ], "contributorsPerLine": 6, diff --git a/README.md b/README.md index 2d5ca9bfa104..1d869d7e176c 100644 --- a/README.md +++ b/README.md @@ -6,7 +6,7 @@ [![Coverage](https://sonarcloud.io/api/project_badges/measure?project=iluwatar_java-design-patterns&metric=coverage)](https://sonarcloud.io/dashboard?id=iluwatar_java-design-patterns) [![Join the chat at https://gitter.im/iluwatar/java-design-patterns](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/iluwatar/java-design-patterns?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge) -[![All Contributors](https://img.shields.io/badge/all_contributors-370-orange.svg?style=flat-square)](#contributors-) +[![All Contributors](https://img.shields.io/badge/all_contributors-371-orange.svg?style=flat-square)](#contributors-)
@@ -553,6 +553,7 @@ This project is licensed under the terms of the MIT license. Tarun Vishwakarma
Tarun Vishwakarma
💻 Shahd Hossam
Shahd Hossam
💻 Mehdi Rahimi
Mehdi Rahimi
💻 + Clint Airé
Clint Airé
💻