Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the writing frquency of partitioned-pipe #257

Merged
merged 1 commit into from
Feb 4, 2022

Conversation

MakisH
Copy link
Member

@MakisH MakisH commented Feb 3, 2022

While running the partitioned-pipe in an OpenFOAM Adapter custom build, I noticed that the results were approx. 160MB in size, which is, I think, unreasonable for what we need.

This increases the writeTime from 0.01 to 0.1. This is 10x fewer files, while 0.1s is still enough to capture the initial discontinuity (this may turn interesting later on in results comparisons).

I did not switch on results compression (i.e., making the output files binary), since eventually we may want to store them as reference results here and make some easy-to-check file comparisons, at least for the last time. If in the end we only check preCICE VTK files, we can enable compression everywhere.

@davidscn does this sound reasonable? Should we absolutely apply the same change to some other tutorial? If not, feel free to merge.

@MakisH MakisH requested a review from davidscn February 3, 2022 21:57
Copy link
Member

@davidscn davidscn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be relevant when working on precice/openfoam-adapter#93

@davidscn davidscn merged commit 32d8b89 into develop Feb 4, 2022
@davidscn davidscn deleted the reduce-output-partitioned-pipe branch February 4, 2022 08:08
@MakisH MakisH added this to the v202104.2.0 milestone Feb 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants