Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Adapter Installation #5

Open
BenjaminRodenberg opened this issue Jan 29, 2019 · 2 comments
Open

Improve Adapter Installation #5

BenjaminRodenberg opened this issue Jan 29, 2019 · 2 comments
Assignees

Comments

@BenjaminRodenberg
Copy link
Member

BenjaminRodenberg commented Jan 29, 2019

Tell Fluent to use PRECICE_ROOT (Solved!)

Currently, we have to manually copy libprecice.so into libudf/lnamd64. The better approach would be to provide PRECICE_ROOT/build/last to Fluent, such that Fluent can find libprecice.so on its own.

Don't use symbolic links to src files

Symbolic links that are created during compilation of the adapter cannot be used by Fluent.

Our work-around here is to just copy-paste all src files from adapter/src into fluent-case/. However, this is not optimal. Can we somehow set an include path for Fluent, or similar?

Don't copy language bindings (Solved!)

see #1 (comment)

Provide alternative to distributing ANSYS Makefiles for compiling the adapter

Currently the adapter files include multiple ANSYS makefiles which are used to compile the adapter. These makefiles are copyrighted and cannot be distributed with the open-source adapter package. An alternative strategy to compile the adapter needs to be devised.

  • Currently the most feasible idea is to provide documentation to guide the user on how to convert a FLUENT makefile for use to compile the adapter
@BenjaminRodenberg BenjaminRodenberg changed the title Tell Fluent to use PRECICE_ROOT Improve Adapter Installation Jan 29, 2019
@IshaanDesai
Copy link
Member

IshaanDesai commented Mar 13, 2020

Points to consider:

  • Manually copying libprecice.so, libprecice.so.2 and libprecice.so.2.0.0 in the directory where fluent.cas and the .scm files exist is still necessary for FLUENT to find preCICE. Solution: --> Adding pkgconfig paths at appropriate locations in makefiles has solved this.
  • The manual copying of src/ directory from the compiled state of the adapter to the directory where the FLUENT case is saved is still necessary because the adapter compilation creates symbolic links between the compiled UDF files in the folders 2d_node/ and 2d_host/ and the src/ directory. Currently this seems to be unavoidable.

@BenjaminRodenberg
Copy link
Member Author

We definitely need an update of the installation procedure. This is something that I would consider critical for a minimal working state. A third-party user should be able to install and run the adapter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants