-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adUnit.ortbConfig
can not customize OpenRTB objects like /imp[].video.api
#801
Comments
@OlenaPostindustria, @ValentinPostindustria please verify that the latest updates for |
Hello.
Resulting
Note: OpenRTB functionality merges JSON arrays. Therefore, if the SDK generates |
Hi, the iOS SDK 2.3.1 sets the proposed properties correctly via the new "imp": [{
"banner": {
"api": [3, 5, 6, 7],
"format": [{
"h": 50,
"w": 320
}]
},
"clickbrowser": 1,
"displaymanager": "prebid-mobile",
"displaymanagerver": "2.3.1",
"ext": {
"prebid": {
"storedrequest": {
"id": "prebid-demo-banner-320-50"
}
}
},
"id": "1F2629F4-DEA4-4FDB-B3B7-7C97770168F5",
"instl": 0,
"secure": 1,
"video": {
"api": [5, 6, 7],
"mimes": ["video\/ogg"],
"pos": 10
}
}], |
Describe the bug
Unlike GAM oringial integration API (e.g.
VideoParameters.java
), other integration types (e.g. AdMob integration) does not provide basic setter methods (e.g.setApi
) to customize OpenRTB params.I can customize some of OpenRTB objects (e.g.
/bidfloor
,/app.content.cat
) viaadUnit.ortbConfig
.However, I have difficulty to customize any OpenRTB objects inside the
/imp[]
array (e.g./imp[].video.api
,/imp[].video.protocols
, etc).To Reproduce
Based on the demo app AdMobVideoInterstitialActivity.kt, I tried to use the
adUnit.ortbConfig
to add/imp[0].video.api: [5,6,7]
, but all of them does not work as I expected. See Additional context section below for more detail.Expected behavior
There should be a method to customize OpenRTB objects like
/imp[].video.api
,/imp[].video.mimes
,/imp[].banner.pos
and so on for generic integration types.Additional context
Testing
adUnit.ortbConfig
as below.adUnit?.ortbConfig = "{\"imp\":[{\"video\":{\"api\":[5,6,7]}}]}"
Then, POST payload to Prebid Server is below.
adUnit?.ortbConfig = "{\"imp\":{\"video\":{\"api\":[5,6,7]}}}"
Then, POST payload (omit irrelevant objects like
/app
,device
) to Prebid Server is below.adUnit?.ortbConfig = "{\"imp[0]\": {\"video\":{\"api\":[5,6,7]}}}"
Then, POST payload (omit irrelevant objects like
/app
,device
) to Prebid Server is below.adUnit?.ortbConfig = "{imp[0].video.api=[5,6,7]}"
Then, POST payload (omit irrelevant objects like
/app
,device
) to Prebid Server is below.The text was updated successfully, but these errors were encountered: