Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.1.1 findPrebidCreativeSize function does not work with Compile error #116

Closed
yoalex5 opened this issue Jun 27, 2019 · 1 comment
Closed
Assignees
Labels

Comments

@yoalex5
Copy link
Collaborator

yoalex5 commented Jun 27, 2019

Type of issue

bug

Description

If add PrebidSDK as Maven artifact AndroidStudio does not see Util.CreativeSizeCompletionHandler and Util.CreativeSize

Screen Shot 2019-06-27 at 1 28 58 PM

Screen Shot 2019-06-27 at 1 31 21 PM

Steps to reproduce

  1. Create a new Android project
  2. add PrebidSDK Maven artifact (build.gradle(module) -> dependencies scope -> implementation 'org.prebid:prebid-mobile-sdk:1.1.1')
  3. Try to use utility function Util.findPrebidCreativeSize()

Expected results

Utility classes(CreativeSizeCompletionHandler, CreativeSize) should be available from a client side

Actual results

Static nested classes are not open to use

Platform details

PrebidSDK v1.1.1

Other information

I think that the issue is in proguard

The API

dfpAdView.setAdListener(new AdListener() {
    @Override
    public void onAdLoaded() {
        super.onAdLoaded();

        Util.findPrebidCreativeSize(dfpAdView, new Util.CreativeSizeCompletionHandler() {
            @Override
            public void onSize(@Nullable Util.CreativeSize size) {
                if (size != null) {
                    dfpAdView.setAdSizes(new AdSize(size.getWidth(), size.getHeight()));
                }
            }
        });

    }
});
@yoalex5 yoalex5 changed the title 1.1.1 Compile issue 1.1.1 findPrebidCreativeSize function does not work with Compile error Jun 27, 2019
@bszekely1 bszekely1 added the bug label Jun 27, 2019
@bszekely1
Copy link
Contributor

Resolved with 1.1.2 release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants