Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to remove existing line items #21

Closed
Winterborne opened this issue Jan 26, 2021 · 6 comments
Closed

Option to remove existing line items #21

Winterborne opened this issue Jan 26, 2021 · 6 comments
Labels
enhancement New feature or request

Comments

@Winterborne
Copy link

Sometimes it becomes important to remove line items one already has set up for a bidder. A bidder might not be generating enough be producing enough demand to justify its place in the stack, or start exhibiting payment problems. Or you might decide you want to rework their line items, perhaps changing the size of the increments between each item.

It would be great for the tool to offer a command to remove existing line items. If done right, this could both speed up the line item removal process, and provide some double-checks to make sure the correct line items are being removed.

Thank you for the tool!

@stygianmessiah
Copy link

Hi @Winterborne,

Thanks for this suggestion. When you say "remove" do you mean deleting line items or just archiving them? Once a line item starts delivering it cannot be deleted, but it can be archived.

The reasoning for not including this by default, was that archiving means those line items stop being active and it could potentially cause the publisher to lose revenue if not done correctly. Hence, it must be done very carefully. However, it is a good feature and can make line item management more efficient.

@Winterborne
Copy link
Author

I mean "archive" in this case, for the reason you cite.

@dshore
Copy link
Collaborator

dshore commented Jan 26, 2021

I do not think this would be difficult to implement. But does feel like a new category of operations requiring a new subcommand, something like:

line_item_manager archive ...

Any suggestions on specifying what we would archive, e.g. by line item id, order id, names??

@dshore dshore added the enhancement New feature or request label Jan 26, 2021
@dshore
Copy link
Collaborator

dshore commented Jan 28, 2021

@Winterborne any thoughts on above? Specifying what to archive?

@dshore
Copy link
Collaborator

dshore commented Feb 9, 2021

See: examples/bin/archive_order.py

Try:
python examples/bin/archive_order.py -h

@dshore
Copy link
Collaborator

dshore commented Feb 9, 2021

Released with: v0.1.15

@dshore dshore closed this as completed Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants