-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to remove existing line items #21
Comments
Hi @Winterborne, Thanks for this suggestion. When you say "remove" do you mean deleting line items or just archiving them? Once a line item starts delivering it cannot be deleted, but it can be archived. The reasoning for not including this by default, was that archiving means those line items stop being active and it could potentially cause the publisher to lose revenue if not done correctly. Hence, it must be done very carefully. However, it is a good feature and can make line item management more efficient. |
I mean "archive" in this case, for the reason you cite. |
I do not think this would be difficult to implement. But does feel like a new category of operations requiring a new subcommand, something like:
Any suggestions on specifying what we would archive, e.g. by line item id, order id, names?? |
@Winterborne any thoughts on above? Specifying what to archive? |
See: examples/bin/archive_order.py Try: |
Released with: v0.1.15 |
Sometimes it becomes important to remove line items one already has set up for a bidder. A bidder might not be generating enough be producing enough demand to justify its place in the stack, or start exhibiting payment problems. Or you might decide you want to rework their line items, perhaps changing the size of the increments between each item.
It would be great for the tool to offer a command to remove existing line items. If done right, this could both speed up the line item removal process, and provide some double-checks to make sure the correct line items are being removed.
Thank you for the tool!
The text was updated successfully, but these errors were encountered: