Branch jd 021015 #52
Merged
Branch jd 021015 #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
October 2, 2015 11:20
…sut commented out
robertrmartinez
added a commit
that referenced
this pull request
Mar 31, 2020
* Price Floors (#52) * Initial Commit Code cleanup + PBS Changes + tests still needed * Refactor to remove event * forgot to remove FLOOR_NOT_MET * Clean up code * broke out req params * floorNotMet is not bidRejected * clean up module, more requirements on bid and analytics adapters moved gpt matching into a util function * test updates + currency conversion now on global * asdf * floor data object schema changed updated to object not array * Selection function now needs to sort by number of *'s in the rule Rubicon get video floor use actual player size * Updated json schema * tests finished * domain is more sophisticated now * Currency floors refactored a little Added log for when bid is floored * update tests after additional data passed to analytics * analytics reqs updated * test update * update to cache lookups Analytics adapter update tests updated for cache lookup * reverting temp stuff * Pulling latest from master = few probs Small currency bug * revert newline * improved rule selection for getFloor * new api for adding new fields overrides if debug on, resp hook after debug hook small bug in overwriting data object * handle adjustment factor of 0 * removed size and mt specific logic and pushed to matching func * adding comments for all funcs * Added tests for rubicon adapters handle matchign keys with dot's * undefined data should be ignored * remove unnecessary -1 plus semi colon * md file * removing temp test file * prebid uses native image size as a single array so we wrap it * Forgot IE 11 no have includes! * if enforcement not passed in default it Exact match not found, then * * no need to decode uri entire url when just wanting hostname * setting auctionId on bidRequests so `onBeforeRequestBids` has context for getFloor() * rubi analytics new values * js rounding fix + isNaN handling * random parenthesis * fixing formula Co-authored-by: rmartinez <Rachael24!>
rjvelicaria
referenced
this pull request
in openx/Prebid.js
Apr 9, 2020
* Price Floors (#52) * Initial Commit Code cleanup + PBS Changes + tests still needed * Refactor to remove event * forgot to remove FLOOR_NOT_MET * Clean up code * broke out req params * floorNotMet is not bidRejected * clean up module, more requirements on bid and analytics adapters moved gpt matching into a util function * test updates + currency conversion now on global * asdf * floor data object schema changed updated to object not array * Selection function now needs to sort by number of *'s in the rule Rubicon get video floor use actual player size * Updated json schema * tests finished * domain is more sophisticated now * Currency floors refactored a little Added log for when bid is floored * update tests after additional data passed to analytics * analytics reqs updated * test update * update to cache lookups Analytics adapter update tests updated for cache lookup * reverting temp stuff * Pulling latest from master = few probs Small currency bug * revert newline * improved rule selection for getFloor * new api for adding new fields overrides if debug on, resp hook after debug hook small bug in overwriting data object * handle adjustment factor of 0 * removed size and mt specific logic and pushed to matching func * adding comments for all funcs * Added tests for rubicon adapters handle matchign keys with dot's * undefined data should be ignored * remove unnecessary -1 plus semi colon * md file * removing temp test file * prebid uses native image size as a single array so we wrap it * Forgot IE 11 no have includes! * if enforcement not passed in default it Exact match not found, then * * no need to decode uri entire url when just wanting hostname * setting auctionId on bidRequests so `onBeforeRequestBids` has context for getFloor() * rubi analytics new values * js rounding fix + isNaN handling * random parenthesis * fixing formula Co-authored-by: rmartinez <Rachael24!>
iggyfisk
pushed a commit
to happypancake/Prebid.js
that referenced
this pull request
Jun 22, 2020
* Price Floors (prebid#52) * Initial Commit Code cleanup + PBS Changes + tests still needed * Refactor to remove event * forgot to remove FLOOR_NOT_MET * Clean up code * broke out req params * floorNotMet is not bidRejected * clean up module, more requirements on bid and analytics adapters moved gpt matching into a util function * test updates + currency conversion now on global * asdf * floor data object schema changed updated to object not array * Selection function now needs to sort by number of *'s in the rule Rubicon get video floor use actual player size * Updated json schema * tests finished * domain is more sophisticated now * Currency floors refactored a little Added log for when bid is floored * update tests after additional data passed to analytics * analytics reqs updated * test update * update to cache lookups Analytics adapter update tests updated for cache lookup * reverting temp stuff * Pulling latest from master = few probs Small currency bug * revert newline * improved rule selection for getFloor * new api for adding new fields overrides if debug on, resp hook after debug hook small bug in overwriting data object * handle adjustment factor of 0 * removed size and mt specific logic and pushed to matching func * adding comments for all funcs * Added tests for rubicon adapters handle matchign keys with dot's * undefined data should be ignored * remove unnecessary -1 plus semi colon * md file * removing temp test file * prebid uses native image size as a single array so we wrap it * Forgot IE 11 no have includes! * if enforcement not passed in default it Exact match not found, then * * no need to decode uri entire url when just wanting hostname * setting auctionId on bidRequests so `onBeforeRequestBids` has context for getFloor() * rubi analytics new values * js rounding fix + isNaN handling * random parenthesis * fixing formula Co-authored-by: rmartinez <Rachael24!>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch contains below changes:
{
bidder: "appnexus",
params: {
placementId: tagid,
query: { key: 2, key1: "value1"}
}
}