From 00c4b706ed44b66e9338b69d90db0988c09beb07 Mon Sep 17 00:00:00 2001 From: "le.labat" Date: Mon, 8 Apr 2024 17:19:56 +0200 Subject: [PATCH 1/2] Criteo Bid Adapter: Fix invalid DSA adrender field mapping --- modules/criteoBidAdapter.js | 4 ++-- test/spec/modules/criteoBidAdapter_spec.js | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/criteoBidAdapter.js b/modules/criteoBidAdapter.js index c1fcac4ae2f..2c0cacb7909 100644 --- a/modules/criteoBidAdapter.js +++ b/modules/criteoBidAdapter.js @@ -255,8 +255,8 @@ export const spec = { if (slot.ext?.meta?.networkName) { bid.meta = Object.assign({}, bid.meta, { networkName: slot.ext.meta.networkName }) } - if (slot.ext?.dsa?.adrender) { - bid.meta = Object.assign({}, bid.meta, { adrender: slot.ext.dsa.adrender }) + if (slot.ext?.dsa) { + bid.meta = Object.assign({}, bid.meta, { dsa: slot.ext.dsa }) } if (slot.native) { if (bidRequest.params.nativeCallback) { diff --git a/test/spec/modules/criteoBidAdapter_spec.js b/test/spec/modules/criteoBidAdapter_spec.js index 1709acb465f..2cdb09f2098 100755 --- a/test/spec/modules/criteoBidAdapter_spec.js +++ b/test/spec/modules/criteoBidAdapter_spec.js @@ -2060,7 +2060,7 @@ describe('The Criteo bidding adapter', function () { }; const bids = spec.interpretResponse(response, request); expect(bids).to.have.lengthOf(1); - expect(bids[0].meta.adrender).to.equal(1); + expect(bids[0].meta.dsa.adrender).to.equal(1); }); it('should properly parse a bid response with a networkId with twin ad unit banner win', function () { From 6b441019f82d4cdb6f85acbeb1aea805742e8a86 Mon Sep 17 00:00:00 2001 From: "le.labat" Date: Wed, 10 Apr 2024 16:13:34 +0200 Subject: [PATCH 2/2] Grid Bid Adapter: Fix invalid DSA adrender field mapping --- modules/gridBidAdapter.js | 4 ++-- test/spec/modules/gridBidAdapter_spec.js | 4 +++- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/modules/gridBidAdapter.js b/modules/gridBidAdapter.js index d56639ed714..f7db6d878f1 100644 --- a/modules/gridBidAdapter.js +++ b/modules/gridBidAdapter.js @@ -554,8 +554,8 @@ function _addBidResponse(serverBid, bidRequest, bidResponses, RendererConst, bid bidResponse.meta.demandSource = serverBid.ext.bidder.grid.demandSource; } - if (serverBid.ext && serverBid.ext.dsa && serverBid.ext.dsa.adrender) { - bidResponse.meta.adrender = serverBid.ext.dsa.adrender; + if (serverBid.ext && serverBid.ext.dsa) { + bidResponse.meta.dsa = serverBid.ext.dsa; } if (serverBid.content_type === 'video') { diff --git a/test/spec/modules/gridBidAdapter_spec.js b/test/spec/modules/gridBidAdapter_spec.js index abaa4b37fcd..efd7b06685f 100644 --- a/test/spec/modules/gridBidAdapter_spec.js +++ b/test/spec/modules/gridBidAdapter_spec.js @@ -1430,7 +1430,9 @@ describe('TheMediaGrid Adapter', function () { 'netRevenue': true, 'ttl': 360, 'meta': { - adrender: 1, + dsa: { + adrender: 1 + }, advertiserDomains: [] }, },