Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consent Management: make getTCData container object on static consent optional #9581

Closed
patmmccann opened this issue Feb 23, 2023 · 4 comments · Fixed by #9664
Closed

Consent Management: make getTCData container object on static consent optional #9581

patmmccann opened this issue Feb 23, 2023 · 4 comments · Fixed by #9664
Assignees

Comments

@patmmccann
Copy link
Collaborator

Type of issue

Bug

Description

IABTL Action Plan likely will deprecate getTCData. Whether or not this happens, it is recommended not to use it. Let's immediately remove all references to it from the project. Luckily most references are just in unit tests, as consentManagement.js only uses it in the case of static consent

@patmmccann
Copy link
Collaborator Author

Tagging #8539 as this change is breaking

https://docs.prebid.org/dev-docs/modules/consentManagement.html example 3 will need to change

@dgirardi
Copy link
Collaborator

I am not sure this is worth the breaking change. getTCData appears to be a remnant from TCFv1, it's not useful anymore, but forcing a rename to something else seems to me like pure friction with no advantage.

@dgirardi
Copy link
Collaborator

dgirardi commented Feb 23, 2023

Agreed offline that we should make the getTCData configuration "container" optional, e.g. support both gdpr: {consentData: {getTCData: {...}}} and gdpr: {consentData: {...}}

@patmmccann patmmccann changed the title Consent Management: remove dependence on getTCData Consent Management: make getTCData container object on static consent optional Feb 23, 2023
@dgirardi dgirardi moved this from Ready for Dev to PR submitted in Prebid.js Tactical Issues table Mar 14, 2023
@github-project-automation github-project-automation bot moved this from PR submitted to Done in Prebid.js Tactical Issues table Mar 19, 2023
@patmmccann
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants