Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate adserver.js? #8779

Closed
patmmccann opened this issue Aug 4, 2022 · 5 comments · Fixed by #8855
Closed

Deprecate adserver.js? #8779

patmmccann opened this issue Aug 4, 2022 · 5 comments · Fixed by #8855
Assignees
@caseywhitmire
Labels
8.0 API Change

Comments

@patmmccann
Copy link
Collaborator

patmmccann commented Aug 4, 2022 •
edited
Loading

adserver.js appears to be completely replaced by https://github.com/prebid/Prebid.js/blob/master/modules/dfpAdServerVideo.js and also has really poor coverage (https://coveralls.io/builds/51056221/source?filename=src%2Fadserver.js ). Should it just be deleted?
@patmmccann
Copy link
Collaborator Author

@spormeon are you using this?

@patmmccann patmmccann mentioned this issue Aug 4, 2022
Closed
@spormeon
Copy link

spormeon commented Aug 4, 2022 •
edited
Loading

ye, as in the dfpadservervideo module

@spormeon
Copy link

spormeon commented Aug 4, 2022

oh, this is/ was the PPID "add on" in effect?, so ye on that as well

@patmmccann
Copy link
Collaborator Author

This is distinct from that, it appears to be how dfp video was done before the dfp video module

@spormeon
Copy link

spormeon commented Aug 4, 2022

negative then, i use the module

@patmmccann patmmccann moved this from Triage to Ready for Dev in Prebid.js Tactical Issues table Aug 15, 2022
@patmmccann patmmccann linked a pull request Aug 17, 2022 that will close this issue
PBJs Core (adserver.js) : remove unused code #8855
Merged
9 tasks
Repository owner moved this from Ready for Dev to Done in Prebid.js Tactical Issues table Aug 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caseywhitmire caseywhitmire

Labels
8.0 API Change
Projects
Prebid.js Tactical Issues table
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PBJs Core (adserver.js) : remove unused code caseywhitmire/Prebid.js
4 participants
@patmmccann @ChrisHuie @spormeon @caseywhitmire