Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More dynamic floormin #7626

Closed
patmmccann opened this issue Oct 25, 2021 · 10 comments · Fixed by #8396
Closed

More dynamic floormin #7626

patmmccann opened this issue Oct 25, 2021 · 10 comments · Fixed by #8396
Assignees
Labels

Comments

@patmmccann
Copy link
Collaborator

patmmccann commented Oct 25, 2021

Type of issue

Feature

Description

#5805 allowed for minimums to floors as a page level variable, but we need floorMin at slot, and potentially other granularity, etc level.

@patmmccann
Copy link
Collaborator Author

patmmccann commented Apr 29, 2022

resolvedFloorsData.data = getFloorDataFromAdUnits(adUnits);
seems to allow for the object with the floor min
if (resolvedFloorsData.hasOwnProperty('floorMin')) resolvedFloorsData.data.floorMin = resolvedFloorsData.floorMin;
to come from the ad unit; is this accurate?

If so, could this be solved with documentation? We need floormin for each ad unit, not necessarily arbitrary syntax.

@patmmccann
Copy link
Collaborator Author

I like @bretg proposal: Support a floormin override on adunit.ortb2Imp.ext.prebid.floorMin ; marking this as ready for dev

@patmmccann patmmccann moved this from Needs Req to Ready for Dev in Prebid.js Tactical Issues table Apr 29, 2022
@robertrmartinez
Copy link
Collaborator

So the change is to:

Update the price floors module to look for floorMin at adunit.ortb2Imp.ext.prebid.floorMin first, and then do whatever it does now to find it if not?

@bretg @patmmccann

@patmmccann
Copy link
Collaborator Author

yes; this would allow for it to vary over ad units, no?

@robertrmartinez
Copy link
Collaborator

Yep it is a good idea!

I'll try and get this and #8339 done over the weekend or something!

@dgirardi dgirardi moved this from Ready for Dev to Tracking in Prebid.js Tactical Issues table May 3, 2022
@patmmccann patmmccann moved this from Tracking to In progress in Prebid.js Tactical Issues table May 6, 2022
@patmmccann patmmccann linked a pull request May 9, 2022 that will close this issue
1 task
@patmmccann patmmccann moved this from In progress to PR submitted in Prebid.js Tactical Issues table May 9, 2022
Repository owner moved this from PR submitted to Done in Prebid.js Tactical Issues table May 10, 2022
@muuki88
Copy link
Collaborator

muuki88 commented May 30, 2022

This looks super useful. Does this also work if there's no floor information at all?

Currently we set our floors something like this

floors: {
  currency: config.currency.adServerCurrency,
  schema: {
    delimiter: '|',
    fields: ['mediaType']
  },
  values: {
    // provided from somewhere else
    '*': priceRule.floorprice
  }
}

With this extension would it be possible to leaf the floors property undefined and only set

ortb2Imp: {
  ext: {
    prebid: {
      floorMin: priceRules.floorprice
    }
  }
}

@patmmccann
Copy link
Collaborator Author

I got so excited i merged without docs, apologies :)

we're implementing shortly.

@patmmccann
Copy link
Collaborator Author

@muuki88 did you figure out the answer to that in test?

@muuki88
Copy link
Collaborator

muuki88 commented Aug 3, 2022

@patmmccann unforunately not. I'll put this on my teams agenda

@patmmccann
Copy link
Collaborator Author

I haven't tested, but I suspect that would not work. You might be able to get away with just the currency or something though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging a pull request may close this issue.

4 participants