-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More dynamic floormin #7626
Comments
Prebid.js/modules/priceFloors.js Line 359 in 061eb3c
Prebid.js/modules/priceFloors.js Line 373 in 061eb3c
If so, could this be solved with documentation? We need floormin for each ad unit, not necessarily arbitrary syntax. |
I like @bretg proposal: Support a floormin override on adunit.ortb2Imp.ext.prebid.floorMin ; marking this as ready for dev |
So the change is to: Update the price floors module to look for floorMin at |
yes; this would allow for it to vary over ad units, no? |
Yep it is a good idea! I'll try and get this and #8339 done over the weekend or something! |
This looks super useful. Does this also work if there's no floor information at all? Currently we set our floors something like this floors: {
currency: config.currency.adServerCurrency,
schema: {
delimiter: '|',
fields: ['mediaType']
},
values: {
// provided from somewhere else
'*': priceRule.floorprice
}
} With this extension would it be possible to leaf the ortb2Imp: {
ext: {
prebid: {
floorMin: priceRules.floorprice
}
}
} |
I got so excited i merged without docs, apologies :) we're implementing shortly. |
@muuki88 did you figure out the answer to that in test? |
@patmmccann unforunately not. I'll put this on my teams agenda |
I haven't tested, but I suspect that would not work. You might be able to get away with just the currency or something though. |
Type of issue
Feature
Description
#5805 allowed for minimums to floors as a page level variable, but we need floorMin at slot, and potentially other granularity, etc level.
The text was updated successfully, but these errors were encountered: