Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Links inside a repeater not working #498

Closed
jlduran opened this issue Jun 1, 2013 · 5 comments
Closed

Links inside a repeater not working #498

jlduran opened this issue Jun 1, 2013 · 5 comments

Comments

@jlduran
Copy link

jlduran commented Jun 1, 2013

I don't think this should be the normal behavior, but:

repeat :all do
  text "<link href='http://example.com'>external link</link>", inline_format: true
end

produces a PDF with no link.

The /URI (http://example.com) is there, however, does not work.

@gchan
Copy link

gchan commented Jan 21, 2014

If you pass the option :dynamic and set it to true, it should work.

repeat :all, dynamic: true do
  text "<link href='http://example.com'>external link</link>", inline_format: true
end

Not sure if that's the expected behaviour however.

@practicingruby
Copy link
Member

@gchan: Looks like so, yep. The ticket was only closed because we did a one-time bulk closure of tickets without recent activity in early November. Since it has a reproducing example and still is broken on master, I've re-opened.

@practicingruby
Copy link
Member

Right now my backlog is deep, so anyone who wants to take a crack at solving this issue or at least researching it further is welcome to do so. I wouldn't expect this should need to use dynamic: true even if that's a workaround for now.

@gchan
Copy link

gchan commented Jan 21, 2014

@sandal I've updated my comment above with the workaround. Thanks for the prompt response!

@practicingruby
Copy link
Member

I've confirmed that #801 is a direct reproduction of this problem at the stamp level, so please follow that ticket for future updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

3 participants