Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operator sidecar improvements #358

Closed
azun opened this issue Jul 1, 2021 · 0 comments · Fixed by #352
Closed

Operator sidecar improvements #358

azun opened this issue Jul 1, 2021 · 0 comments · Fixed by #352

Comments

@azun
Copy link
Contributor

azun commented Jul 1, 2021

Description

Sidecar support was added in #344 . This works fine but there are some pain points when using zookeeper-operator as a helm dependency:

  • the sidecar manifest can't be easily reused between dependencies/other pods
  • no way to use templates for the sidecars (must specify the full Container struct)
  • repetitive across multiple installations: no way to overwrite values for a container as arrays are concatenated by helm

Importance

nice-to-have

Location

charts/zookeeper-operator/templates/

Suggestions for an improvement

The additionalSidecar property can be wrapped inside a named template. This generic template would use the data as it's defined in values.yaml. The parent chart would then be able to overwrite it and define container templates that can be reused and parameterized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants