Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No pre-delete hook in zookeeper-operator chart #300

Closed
jkhalack opened this issue Jan 28, 2021 · 0 comments · Fixed by #301
Closed

No pre-delete hook in zookeeper-operator chart #300

jkhalack opened this issue Jan 28, 2021 · 0 comments · Fixed by #301

Comments

@jkhalack
Copy link
Contributor

jkhalack commented Jan 28, 2021

Description

The zookeeper-operator helm chart does not have a pre-delete hook in it.
As a result, the operator can be uninstalled with orphan custom resources hanging around.

The orphan custom resources cannot be deleted, because they have finalizers that are supposed to be cleared by the operator. However, the operator is gone at this point.

Even the operator is reinstalled, it most probably won't be able to clean up the above custom resource if its parent namespace had been marked for deletion and is stuck in the terminated state because of that orphan custom resource.

Importance

should-have

Location

zookeeper-operator helm chart

Suggestions for an improvement

Please, add a pre-delete hook to the operator chart that would verify that all custom resources have been cleaned up before deleting the operator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant