diff --git a/common/copr_common/subprocess_live_output.py b/common/copr_common/subprocess_live_output.py index 5c212e5e9..2b668d37e 100644 --- a/common/copr_common/subprocess_live_output.py +++ b/common/copr_common/subprocess_live_output.py @@ -150,8 +150,7 @@ def _kill(): return self.killed = True process.kill() - while process.poll(): - pass + assert not process.poll() # at least EL7 needs this process.stdout.close() process.stderr.close() diff --git a/pylintrc b/pylintrc index 717d11c85..8a417d76d 100644 --- a/pylintrc +++ b/pylintrc @@ -51,7 +51,10 @@ load-plugins=pylint_copr_plugin # cyclic-import # Seems like cyclic-import is just a style check which is not going to be # fixed: https://github.com/PyCQA/pylint/issues/6983 -disable=import-error,too-few-public-methods,consider-using-f-string,cyclic-import +# too-many-instance-attributes +# Local variables are often pretty hard to avoid, yet switching to +# dataclasses almost never makes sense. +disable=import-error,too-few-public-methods,consider-using-f-string,cyclic-import,too-many-instance-attributes [VARIABLES] # A regular expression matching names used for dummy variables (i.e. not used). diff --git a/pylintrc_clients b/pylintrc_clients index 594f6001d..c10455331 100644 --- a/pylintrc_clients +++ b/pylintrc_clients @@ -29,7 +29,10 @@ load-plugins=pylint_copr_plugin # We still support Python 2.7 (EL7) for clients. # unspecified-encoding # Python2.7: TypeError: 'encoding' is an invalid keyword argument for this function -disable=import-error,useless-object-inheritance,super-with-arguments,consider-using-f-string,unspecified-encoding +# too-many-instance-attributes +# Local variables are often pretty hard to avoid, yet switching to +# dataclasses almost never makes sense. +disable=import-error,useless-object-inheritance,super-with-arguments,consider-using-f-string,unspecified-encoding,too-many-instance-attributes [VARIABLES] # A regular expression matching names used for dummy variables (i.e. not used).