Download replay button incorrectly available upon completing a play

[Azn9]

Describe the crash: The game crash if we rapidly click on the download replay button. Maybe this is related to the issue the game alert for when clicking on the download button?

Screenshots or videos showing the encountered issue: https://youtu.be/zI7Bzxofo3g

osu!lazer version: 2019.930.0.0

Logs: runtime.log

Computer Specifications: CPU: Intel Core i5 8th generation, RAM: 8Go, Graphics card: NVidia GTX 1060 3Go, Windows 10 64bits

[bdach]

This is the original location for the error:

osu/osu.Game/Scoring/LegacyDatabasedScore.cs

Line 19 in d2ee08a

var replayFilename = score.Files.First(f => f.Filename.EndsWith(".osr", StringComparison.InvariantCultureIgnoreCase)).FileInfo.StoragePath;

It would appear that even though the download button looks like the replay should be downloaded, the replay file is not actually present in the database. Do you mind uploading your database file? It's located at %AppData%/osu/client.db.

[Gabixel]

Did you complete the map on Lazer? I can reproduce this issue when finishing a map: the replay download button is "completed", but when I click on it, an error pops up. For what I know, replays from Lazer gameplay are not implemented yet: only imported replays are available (leaderboards included).

[Azn9]

Sorry for the delay ^-^'

Here is the file @bdach : client.zip
Yes @Gabixel I completed the map on lazer, this is the score screen showing up at the end of the gameplay

[bdach]

Strange, when I try to reproduce this by completing a play on 2019.930.0 the download button is showing Replay unavailable as it should... I'll take a look at the DB file now, but to tell you the truth I don't currently understand why there is a difference.

Edit: I've looked through the DB file. I can't even see the score that was set in the attached video in there.

[bdach]

I've renamed this to track the actual problem better. Still not sure how to get this to reproduce.

[Joehuu]

Should not happen anymore since replays for lazer plays are implemented in #8428.