Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mania LegacyComboCounter get a shadow backdrop when counter increases #20541

Closed
Endroma1 opened this issue Oct 1, 2022 · 5 comments · Fixed by #26254
Closed

Mania LegacyComboCounter get a shadow backdrop when counter increases #20541

Endroma1 opened this issue Oct 1, 2022 · 5 comments · Fixed by #26254

Comments

@Endroma1
Copy link

Endroma1 commented Oct 1, 2022

Type

Cosmetic

Bug description

LegacyComboCounter gets a shadow behind itself when the counter increases like the stable counter. This is very distracing when using the combo counter as a reference point.

Skin: https://mega.nz/file/C2QVjKZC#OxGzqLXNNp7rtmc51E-xMYtdwpcZ7LAQ8m2XzDAwteI

also tested with this skin: https://osu.ppy.sh/community/forums/topics/203238?n=1

Screenshots or videos

Lazer behaviour:
Screenshot 2022-10-01 211429

Stable behaviour:
Screenshot 2022-10-01 211714

Version

2022.923.1

Logs

updater.log
legacy-ipc.log
performance.log
runtime.log
updater.log
updater.log

@smoogipoo
Copy link
Contributor

smoogipoo commented Oct 3, 2022

We cannot fix this, the shadow is baked into the images provided by the skin.

@smoogipoo smoogipoo closed this as not planned Won't fix, can't repro, duplicate, stale Oct 3, 2022
@enoslayd
Copy link

enoslayd commented Oct 3, 2022

Its more of a different animation as the mania and taiko animations aren't added yet

@ghost
Copy link

ghost commented Oct 3, 2022

perhaps a side-by-side video comparison with stable and lazer may help?

as mentioned, it seems to be because the mania combo counter is not implemented (at least, was not implemented the last time i checked) and just uses the one for standard

@peppy
Copy link
Member

peppy commented Oct 3, 2022

I think this is valid to keep open. osu!stable uses a different animation in mania, so we probably want to support that to some degree (similar to how it's handled in osu!catch).

Parallels.Desktop.2022-10-03.at.07.41.21.mp4

@peppy peppy reopened this Oct 3, 2022
@frenzibyte frenzibyte self-assigned this Oct 3, 2022
@reo-the-enby
Copy link

It's the same for taiko

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants