Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching in settings does not show/hide sections correctly #17929

Closed
Gabixel opened this issue Apr 22, 2022 · 2 comments · Fixed by #17931 or #17937
Closed

Searching in settings does not show/hide sections correctly #17929

Gabixel opened this issue Apr 22, 2022 · 2 comments · Fixed by #17931 or #17937
Assignees
Labels
area:settings priority:0 Showstopper. Critical to the next release.

Comments

@Gabixel
Copy link
Contributor

Gabixel commented Apr 22, 2022

Type

Game behaviour

Bug description

I was trying the local version of master for various things (e.g. the new setup screen) when I noticed that the search in the settings seems to behave weirdly and doesn't hide some sections at times.

Screenshots or videos

osu.2022.04.22.-.13.27.38.01_Trim.mp4

Version

master

Logs

N/A

@bdach
Copy link
Collaborator

bdach commented Apr 23, 2022

This is not fully fixed on master for me:

2022-04-23.20-30-56.mp4

#17937 fixes this for me. @frenzibyte please confirm that that pull was supposed to address this? not sure why this issue wasn't reopened if so.

@bdach bdach reopened this Apr 23, 2022
@bdach bdach added priority:0 Showstopper. Critical to the next release. area:settings labels Apr 23, 2022
@bdach bdach changed the title Searching for settings does not hide some sections correctly Searching in settings does not show/hide sections correctly Apr 23, 2022
@frenzibyte
Copy link
Member

frenzibyte commented Apr 23, 2022

Ah right, noticed the issue was still persisting in master after I had submitted the PR already, but forgot to mention it here (mainly about whether it was worth opening the issue if the PR is gonna get merged soon, but perhaps I overestimated that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:settings priority:0 Showstopper. Critical to the next release.
Projects
None yet
3 participants