From 79dd06a1597d0670369b12761a9a6a874ce35f04 Mon Sep 17 00:00:00 2001 From: smoogipoo Date: Tue, 15 Jun 2021 18:40:35 +0900 Subject: [PATCH 1/4] Add inspection error --- osu.Framework/Game.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/osu.Framework/Game.cs b/osu.Framework/Game.cs index 4fbeeb14b8..9aec913991 100644 --- a/osu.Framework/Game.cs +++ b/osu.Framework/Game.cs @@ -3,6 +3,7 @@ using System; using System.Collections.Generic; +using System.IO; using osu.Framework.Allocation; using osu.Framework.Audio; using osu.Framework.Bindables; From 2255f83370a68078e1b2320fcd5a9d55753e3f05 Mon Sep 17 00:00:00 2001 From: smoogipoo Date: Tue, 15 Jun 2021 20:31:15 +0900 Subject: [PATCH 2/4] Use custom NVika build for inspectcode reports --- .config/dotnet-tools.json | 4 ++-- .github/workflows/ci.yml | 6 ++---- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json index d68b041636..1506a6077b 100644 --- a/.config/dotnet-tools.json +++ b/.config/dotnet-tools.json @@ -20,8 +20,8 @@ "jb" ] }, - "nvika": { - "version": "2.0.0", + "smoogipoo.nvika": { + "version": "1.0.0", "commands": [ "nvika" ] diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index e024f76e44..9e3cf11b58 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -91,7 +91,5 @@ jobs: - name: InspectCode run: dotnet jb inspectcode $(pwd)/osu-framework.Desktop.slnf --output=$(pwd)/inspectcodereport.xml --cachesDir=$(pwd)/inspectcode --verbosity=WARN - - name: ReSharper - uses: glassechidna/resharper-action@master - with: - report: ${{github.workspace}}/inspectcodereport.xml + - name: NVika + run: dotnet nvika parsereport "${{github.workspace}}/inspectcodereport.xml" --treatwarningsaserrors From a279645d3e806762f5c7a3bee4aaa89cd140f944 Mon Sep 17 00:00:00 2001 From: smoogipoo Date: Tue, 15 Jun 2021 21:05:18 +0900 Subject: [PATCH 3/4] Upgrade to 1.0.1 --- .config/dotnet-tools.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.config/dotnet-tools.json b/.config/dotnet-tools.json index 1506a6077b..9354ffc0b5 100644 --- a/.config/dotnet-tools.json +++ b/.config/dotnet-tools.json @@ -21,7 +21,7 @@ ] }, "smoogipoo.nvika": { - "version": "1.0.0", + "version": "1.0.1", "commands": [ "nvika" ] From c1583468b4c4d08dc2b5422ffa6acb1df2fef02d Mon Sep 17 00:00:00 2001 From: smoogipoo Date: Tue, 15 Jun 2021 21:34:15 +0900 Subject: [PATCH 4/4] Revert "Add inspection error" This reverts commit 79dd06a1597d0670369b12761a9a6a874ce35f04. --- osu.Framework/Game.cs | 1 - 1 file changed, 1 deletion(-) diff --git a/osu.Framework/Game.cs b/osu.Framework/Game.cs index 9aec913991..4fbeeb14b8 100644 --- a/osu.Framework/Game.cs +++ b/osu.Framework/Game.cs @@ -3,7 +3,6 @@ using System; using System.Collections.Generic; -using System.IO; using osu.Framework.Allocation; using osu.Framework.Audio; using osu.Framework.Bindables;