Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is_pozyx_port false positives #69

Open
dwiel opened this issue Jul 25, 2019 · 2 comments
Open

is_pozyx_port false positives #69

dwiel opened this issue Jul 25, 2019 · 2 comments

Comments

@dwiel
Copy link

dwiel commented Jul 25, 2019

is_pozyx_port checks the vendor id to see if it is 0483, but another device i have also uses that id. Perhaps the product id should also match in the event that the vendor id is being checked.

[   15.003979] usb 1-2.4: New USB device found, idVendor=0483, idProduct=5740
[   15.003984] usb 1-2.4: New USB device strings: Mfr=1, Product=2, SerialNumber=3
[   15.003987] usb 1-2.4: Product: X2.1-777
[   15.003989] usb 1-2.4: Manufacturer: mRo
[   15.003991] usb 1-2.4: SerialNumber: XXX

if "0483:" in port.hwid:

@laurentva
Copy link
Collaborator

Hey Zach,

That's a good call! I'll look into changing this. Out of pure curiosity, what device is this?

@dwiel
Copy link
Author

dwiel commented Sep 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants