From 43ec2695c05c644fe0fd26a47680244b40c9c12c Mon Sep 17 00:00:00 2001 From: Cameron White Date: Tue, 1 Sep 2020 20:16:02 -0400 Subject: [PATCH] Attempt to fix the VC redist installation issues - Try to avoid comparing against a hash from when the installer was built, since MS frequently updates the redist installer from that link. The normal signature verification can be used - Remove caching of the redist for the CI builds, since this resulted in it never being updated. #305 --- .github/workflows/build.yml | 8 -------- installer/windows/installer.wxs | 2 ++ 2 files changed, 2 insertions(+), 8 deletions(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index a06d03c34..b07d36dbf 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -82,15 +82,7 @@ jobs: - uses: microsoft/setup-msbuild@v1.0.0 - - name: Cache VC redist - id: cache-redist - uses: actions/cache@v2 - with: - path: installer/windows/redist/vc_redist.x64.exe - key: ${{ runner.os }}-redist-v1 - - name: Fetch VC redist - if: steps.cache-redist.outputs.cache-hit != 'true' run: | cd installer/windows mkdir redist diff --git a/installer/windows/installer.wxs b/installer/windows/installer.wxs index 721d10325..b2ac2facb 100644 --- a/installer/windows/installer.wxs +++ b/installer/windows/installer.wxs @@ -21,6 +21,7 @@ +