From 00544f70eb0f92e58ac43d944d61ae6c90c719d0 Mon Sep 17 00:00:00 2001 From: Jill Klang Date: Fri, 15 Nov 2024 11:56:39 -0500 Subject: [PATCH 1/2] Test no-op for non-Rails app --- .github/workflows/reviewdog.yml | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml index 60e770e3..5c8d2290 100644 --- a/.github/workflows/reviewdog.yml +++ b/.github/workflows/reviewdog.yml @@ -6,6 +6,18 @@ permissions: pull-requests: write jobs: + brakeman: + name: Security Analysis + runs-on: ubuntu-latest + steps: + - name: Check out code + uses: actions/checkout@v4 + - name: Set up Ruby + uses: ruby/setup-ruby@v1 + - name: Brakeman + uses: reviewdog/action-brakeman@v2 + with: + brakeman_version: gemfile bearer: name: Bearer Security Analysis runs-on: ubuntu-latest From 7881e8ea5fc7d6c698d4563ce61502a8d6cfd59e Mon Sep 17 00:00:00 2001 From: Jill Klang Date: Fri, 15 Nov 2024 14:09:21 -0500 Subject: [PATCH 2/2] Can we use the default github token? --- .github/workflows/reviewdog.yml | 14 -------------- 1 file changed, 14 deletions(-) diff --git a/.github/workflows/reviewdog.yml b/.github/workflows/reviewdog.yml index 5c8d2290..9d935e8f 100644 --- a/.github/workflows/reviewdog.yml +++ b/.github/workflows/reviewdog.yml @@ -6,18 +6,6 @@ permissions: pull-requests: write jobs: - brakeman: - name: Security Analysis - runs-on: ubuntu-latest - steps: - - name: Check out code - uses: actions/checkout@v4 - - name: Set up Ruby - uses: ruby/setup-ruby@v1 - - name: Brakeman - uses: reviewdog/action-brakeman@v2 - with: - brakeman_version: gemfile bearer: name: Bearer Security Analysis runs-on: ubuntu-latest @@ -34,7 +22,5 @@ jobs: output: rd.json - name: Run reviewdog if: always() - env: - REVIEWDOG_GITHUB_API_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | touch rd.json && cat rd.json | reviewdog -f=rdjson -reporter=github-pr-check