PG17: powa.c:701:9: error: implicit declaration of function ‘tuplestore_donestoring’; did you mean ‘tuplestore_rescan’? [-Wimplicit-function-declaration]

[df7cb]

powa-archivist needs patches for PG17, on master 4.2.2:

### PostgreSQL 17 loop ###
# 17: make
make[1]: Verzeichnis „/home/myon/projects/postgresql/powa-archivist/powa-archivist“ wird betreten
gcc -Wall -Wmissing-prototypes -Wpointer-arith -Wdeclaration-after-statement -Werror=vla -Wendif-labels -Wmissing-format-attribute -Wimplicit-fallthrough=3 -Wcast-function-type -Wshadow=compatible-local -Wformat-security -fno-strict-aliasing -fwrapv -fexcess-precision=standard -Wno-format-truncation -Wno-stringop-truncation -g -g -O2 -Werror=implicit-function-declaration -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fno-omit-frame-pointer -g -O2 -Werror=implicit-function-declaration -ffile-prefix-map=/home/myon/projects/postgresql/powa-archivist/powa-archivist=. -fstack-protector-strong -fstack-clash-protection -Wformat -Werror=format-security -fcf-protection -fPIC -fvisibility=hidden -I. -I./ -I/usr/include/postgresql/17/server -I/usr/include/postgresql/internal  -Wdate-time -D_FORTIFY_SOURCE=2 -D_GNU_SOURCE -I/usr/include/libxml2   -c -o powa.o powa.c
powa.c: In function ‘powa_stat_common’:
powa.c:701:9: error: implicit declaration of function ‘tuplestore_donestoring’; did you mean ‘tuplestore_rescan’? [-Wimplicit-function-declaration]
  701 |         tuplestore_donestoring(tupstore);
      |         ^~~~~~~~~~~~~~~~~~~~~~
      |         tuplestore_rescan
make[1]: *** [<eingebaut>: powa.o] Fehler 1

[rjuju]

That was fixed some time ago as of 1a72a7a.

Unfortunately this wasn't released and I since merged all the work for the upcoming v5, which involves a lot of changes and a hard compatibility break. So it's not really possible to release a new v4.2.x at this point, at least not easily (new branch and everything). v5 should be released hopefully soon (the main blocker is that the documentation needs a lot of modifications and this is taking a lot of time).

[df7cb]

Ok I see. There's a few more changes that would have to be backported (pg_stat_checkpointer etc), but the commits don't apply. I'll just wait for v5. Thanks!

[df7cb]

Hi, is v5 making progress? There's only a few packages left to complete the PG17 transition in Debian, powa-archivist being one.

[rjuju]

Hi,

I just released powa-archivist and powa-web version 5.0.0, which adds the pg17 compatibility. Sorry the for delay,

[df7cb]

Thanks!