New sketch page layout and previews #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/pouretrebelle/jigsaws/EWBdyYLVsaqwQ1AwZeDk6V2L5DuM |
pouretrebelle
force-pushed
the
spike/new-layout
branch
from
6d8d3a3
to
9c5a126
Compare
pouretrebelle
force-pushed
the
spike/new-layout
branch
from
9c5a126
to
a4c071c
Compare
pouretrebelle
force-pushed
the
spike/new-layout
branch
from
a4c071c
to
b7edc21
Compare
pouretrebelle
force-pushed
the
spike/new-layout
branch
from
db012c6
to
ebdb72d
Compare
pouretrebelle
force-pushed
the
spike/new-layout
branch
from
ebdb72d
to
f51f459
Compare
pouretrebelle
force-pushed
the
spike/new-layout
branch
from
f51f459
to
5e723f9
Compare
pouretrebelle
changed the title
pouretrebelle
force-pushed
the
spike/new-layout
branch
from
e2a4f8a
to
39c80c5
Compare
pouretrebelle
force-pushed
the
spike/new-layout
branch
from
abd9cb4
to
8c38cfc
Compare
The hsl notation with the alpha channel was working in the browser but not with node-canvas. I spotted this because the node-canvas outputs of 029 were much more saturated than expected.
I was getting 500s on the lambda with the error 'cannot open shared object file: No such file or directory', it looks like it's something to do with node-canvas so here's a weird hack. Automattic/node-canvas#1448 (comment) vercel/vercel#3460 (comment) Added zlib-devel after 'Error: /lib64/libz.so.1: version `ZLIB_1.2.9' not found' error on above changes'
I'm still getting binary build errors from node-canvas, this fix is recommended here Automattic/node-canvas#1448 (comment)
It's impossible to read files in serverless functions from outside the src folder. I've tried a lot of things, including various import workarounds and converting the api route into a separate lambda. This is the most elegant solution for now. See: - vercel/next.js#8251 - vercel/next.js#8251 (comment) - vercel/vercel#3083 (comment)
Vercel has a 10s maximum execution time on hobby plans, so more complex puzzle previews may time out. This adds a cute little sad face if that happens, and improves handling of the loader timeout. See: - https://vercel.com/docs/platform/limits#serverless-function-execution-timeout - https://vercel.com/docs/platform/limits#general-limits
This includes the context.getTransform method which is needed in the preview lambda See: - Automattic/node-canvas#1769 - https://github.com/Automattic/node-canvas/blob/HEAD/CHANGELOG.md#280
On Windows this was copying into src/.temp/sketches/000 but on remote I think it was copying into src/.temp/000, Brian thinks this may fix it.
pouretrebelle
force-pushed
the
spike/new-layout
branch
from
08c49a2
to
1c0bb35
Compare
pouretrebelle
force-pushed
the
spike/new-layout
branch
from
1c0bb35
to
fe1e770
Compare
pouretrebelle
force-pushed
the
spike/new-layout
branch
from
fe1e770
to
62d77f1
Compare
pouretrebelle
force-pushed
the
spike/new-layout
branch
from
731d93f
to
f99bf0f
Compare
I really want to ship these layout changes but continue to have issues with zlib (see Automattic/node-canvas#1779) which I won't have the capacity to investigate or solve for at least a few weeks. Hiding these features and merging until I can look into it fully.
pouretrebelle
force-pushed
the
spike/new-layout
branch
from
f99bf0f
to
7eff3cf
Compare
|
Going to merge this now without my wonderful preview sketches because I want the new layout and this is getting stale. I'll find that zlib fix if it's the last thing I do (but maybe not for a few weeks). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blockers for merge:
Next.js API routes (and pages) should support reading files vercel/next.js#8251Workarounds b0ab7b1 aa7de56 f717eba