Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename gain controls 'IF' and 'RF' and keep the old 'IFGR' and 'RFGR' for backward compatibility without listing them #10

Open
fventuri opened this issue May 30, 2020 · 1 comment
Assignees

Comments

@fventuri
Copy link
Collaborator

As discussed with @SDRplay and @vsonnier, we should rename the gain controls to 'IF' and 'RF', and keep the old gain reduction 'IFGR' and 'RFGR' for backward compatibility without listing them explicitly in 'listGains()'.

This change is now in the 'new-gain-controls' branch.

@dlaw
Copy link

dlaw commented Jan 3, 2021

Some references:

The original SoapySDRPlay2 issue and discussion (December 2018)
pothosware/SoapySDRPlay2#44

My previous PR to fix this in the v2 driver (November 2019)
pothosware/SoapySDRPlay2#61

A discussion about the best path forward (May 2020)
cjcliffe/CubicSDR#825

A branch of SoapySDRPlay3 which implements the changes discussed in the CubicSDR issue (May 2020)
https://github.com/pothosware/SoapySDRPlay3/tree/new-gain-controls

A port of my previous PR to the v3 driver, which I opened while unaware of the above (January 2021)
#26

New PR reconciling my proposed changes with a rebased new-gain-controls branch (January 2021)
#27

Cheers,
David

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants