Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: mkdir if parent dir does not exists #516

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tmg0
Copy link

@tmg0 tmg0 commented Sep 26, 2024

Resolve: #515

  • Use fs.mkdir with recursive before write dts content to the target file
  • Add dts string options to e2e test file

Copy link
Owner

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good, thanks a lot! I will merge later.
My only concern is testing on windows

Copy link

codecov bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 67.54%. Comparing base (5741b2a) to head (33e80c1).

Files with missing lines Patch % Lines
src/core/context.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #516      +/-   ##
==========================================
- Coverage   67.56%   67.54%   -0.03%     
==========================================
  Files          31       31              
  Lines        3074     3075       +1     
  Branches      601      602       +1     
==========================================
  Hits         2077     2077              
- Misses        991      992       +1     
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tmg0
Copy link
Author

tmg0 commented Sep 26, 2024

Thank you for your response!

I have tried to run e2e test script with options.dts: ./.types/__types.d.ts on my Windows, and it seems working good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Auto generate dts file dir
2 participants