Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(loaders): make data always possibly undefined #506

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

posva
Copy link
Owner

@posva posva commented Sep 9, 2024

BREAKING CHANGE: In practice, wrong usage of the data loaders can lead to undefined data even when lazy is false

Close #319

With the introduction of errors, data can actually be undefined in many cases. This is overall more correct and produce less complicated types

BREAKING CHANGE: In practice, wrong usage of the data loaders can lead
to undefined data even when lazy is false
Copy link

codecov bot commented Sep 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.65%. Comparing base (1dcd362) to head (537111e).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #506      +/-   ##
==========================================
- Coverage   67.67%   67.65%   -0.03%     
==========================================
  Files          32       32              
  Lines        3072     3070       -2     
  Branches      600      600              
==========================================
- Hits         2079     2077       -2     
  Misses        987      987              
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@posva posva merged commit 10112a0 into main Sep 9, 2024
10 of 11 checks passed
@posva posva deleted the refactor/loaders-undefined-types-data branch September 9, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Passing server: false should change the type
1 participant