Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server sent events UI doesn't come up when the content-type of the response is text/event-stream; charset=utf-8 #11753

Closed
1 task done
hollowpurple opened this issue Feb 22, 2023 · 4 comments

Comments

@hollowpurple
Copy link

Is there an existing issue for this?

  • I have searched the tracker for existing similar issues and I know that duplicates will be closed

Describe the Issue

Hey guys,
Thank you for adding support for SSE in Postman! I have started using it and have found an issue that I think might be related to this line of code (I might be wrong) -

https://github.com/postmanlabs/postman-runtime/blob/b7c94a069771d99e432398165eb259eb4d17cd77/lib/requester/requester.js#L365

The event list UI doesn't show up in the case when content-type has the value text/event-stream; charset=utf-8

Maybe using .startsWith would fix this?

Steps To Reproduce

  1. Set the content-type header of the response to text/event-stream; charset=utf-8

Screenshots or Videos

  • After appending charset=utf-8
    charset-event-stream

  • Without appending charset=utf-8
    no-charset-event-stream

Operating System

Windows

Postman Version

10.10.7

Postman Platform

Postman App

User Account Type

Signed In User

Additional Context?

No response

@hollowpurple hollowpurple changed the title Server sent events UI doesn't come up when the content-type is text/event-stream; charset=utf-8 Server sent events UI doesn't come up when the content-type of the response is text/event-stream; charset=utf-8 Feb 22, 2023
@codenirvana codenirvana self-assigned this Feb 22, 2023
@codenirvana
Copy link
Member

@hollowpurple you are right. Currently, there's a strict content-type check. We'll fix this soon.

@picpicb
Copy link

picpicb commented Mar 15, 2023

It would be great to handle both. I found a workaround for my api to remove the charset in the header, but i can’t do that in production env.

@codenirvana
Copy link
Member

@picpicb Yes, the fix will be released this week with Postman v10.12.

@appurva21
Copy link
Member

Hey everyone! This issue is now fixed in the latest version of the Postman app (v10.12.0).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants