Bug fixes #81
Merged
Bug fixes #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| headers: Helpers.generateHeaderObj(request.transformed.headers), | ||
| data: this._getTransformedRequestData(request), | ||
| dataMode: request.dataMode | ||
| url: request.transformed.url, |
There was a problem hiding this comment.
Indentation change. Had reverted my Vim settings accidentally and hence the bogus commit.
|
Any traction ? |
|
@viig99 Made the changes to return and indent. Merge now. Will send the PR on transformed data separately. |
| var isSet = false; | ||
|
|
||
| // check if the envVariable already exists | ||
| Globals.envJson.values.forEach(function(envObject) { |
There was a problem hiding this comment.
Please use underscore find to this, and use if-else here instead of early returns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fixes for issues #80, #78, #77
Added an extra collections file to test formdata.