Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fake_value cookie removed, which breaks a test in requests #380

Closed
kevin1024 opened this issue Aug 27, 2017 · 2 comments · Fixed by #392
Closed

fake_value cookie removed, which breaks a test in requests #380

kevin1024 opened this issue Aug 27, 2017 · 2 comments · Fixed by #392

Comments

@kevin1024
Copy link
Contributor

This commit: 791e31c removed the cookie that was always set on the digest endpoint, which breaks a test in requests (see also: this travis failure)

There was some old (never-resolved) discussion of this odd feature here: kennethreitz/httpbin#124

Paging @sigmavirus24 - should we add this behavior back?

See also: psf/requests#4263

@sigmavirus24
Copy link
Contributor

Perhaps it'd be better to do that in a different way. Not ever HTTP client wants to handle Cookies as part of HTTP Digest even though that's patently wrong.

Requests has a test dependent upon that because we broke that at one point and were relying on being able to use HTTPbin to provide us the behaviour so we could verify it.

@kennethreitz
Copy link
Contributor

Pull requests break everything around me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants