Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A flag to bypass DNS resolvabilty check #15

Closed
bychart opened this issue Dec 31, 2021 · 2 comments
Closed

A flag to bypass DNS resolvabilty check #15

bychart opened this issue Dec 31, 2021 · 2 comments

Comments

@bychart
Copy link

bychart commented Dec 31, 2021

Hello! I'd really appreciate it if you'd add a flag to disable the DNS name resolvability validation.
RegExp alone is probably good enough for the testing needs in absence of properly configured DNS server.
Screen Shot 2021-12-30 at 11 52 29 PM
:)

@clementnuss
Copy link
Contributor

Hi!

I will implement that next week, needs a bit of refactoring in the function that does these checks. will be configurable through env var or cmd-line flag !

👋🏻

@clementnuss
Copy link
Contributor

Hi @bychart,

this should be fixed on dev/ and if you use the :latest tag for the csr-approver.
configuration can be changed either with cmdline flag : --bypass-dns-resolution true or
with an environment variable: BYPASS_DNS_RESOLUTION=TRUE

can you confirm that it works for you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants