diff --git a/.github/workflows/publish.yaml b/.github/workflows/publish.yaml index 4e06589..fadd651 100644 --- a/.github/workflows/publish.yaml +++ b/.github/workflows/publish.yaml @@ -102,6 +102,7 @@ jobs: -e 's|tag:.*|tag: latest|g' \ -e 's|providerRegex:.*|providerRegex: ^.+$|g' \ -e 's|maxExpirationSeconds:.*|maxExpirationSeconds: "86400"|g' \ + -e 's|bypassDnsResolution:.*|bypassDnsResolution: true|g' \ charts/kubelet-csr-approver/values.yaml cat charts/kubelet-csr-approver/values.yaml - name: Run chart-testing (install) @@ -136,7 +137,7 @@ jobs: run: | export REF=${{ github.ref}} export COMMIT=${{ github.sha}} - export TAG=$(echo ${{ github.ref }} | cut -d "/" -f 3 - ) + export TAG=$(echo ${{ github.ref }} | cut -d "/" -f 3 - ) ko publish ./cmd/kubelet-csr-approver/ --base-import-paths --platform=linux/amd64,linux/arm64,linux/arm --tags $TAG publish-helm-charts: @@ -160,7 +161,7 @@ jobs: run: | git config user.name "$GITHUB_ACTOR" git config user.email "$GITHUB_ACTOR@users.noreply.github.com" - + - name: Install Helm uses: azure/setup-helm@v1 with: @@ -187,7 +188,7 @@ jobs: with: go-version: 1.17 stable: true - + - name: Login to DockerHub uses: docker/login-action@v1 with: diff --git a/README.md b/README.md index 0b0f23d..078cd89 100644 --- a/README.md +++ b/README.md @@ -60,6 +60,7 @@ helm repo add kubelet-csr-approver https://postfinance.github.io/kubelet-csr-app helm install kubelet-csr-approver kubelet-csr-approver/kubelet-csr-approver -n kube-system \ --set providerRegex='^node-\w*\.int\.company\.ch$' \ --set maxExpirationSeconds='86400' + --set bypassDnsResolution='false' ``` ## Attacker model -- what could go wrong ?