Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typo #296

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix: typo #296

merged 1 commit into from
Oct 30, 2024

Conversation

ryo-manba
Copy link
Contributor

Fixed incorrect default value comments in the Options interface.

See: https://github.com/postcss/postcss-selector-parser/blob/6158750aab0aed3046a5920bd58e0e0266a4ada2/API.md#processoroptions

_shouldUpdateSelector (rule, options = {}) {
let merged = Object.assign({}, this.options, options);
if (merged.updateSelector === false) {
return false;
} else {
return typeof rule !== "string";
}
}
_isLossy (options = {}) {
let merged = Object.assign({}, this.options, options);
if (merged.lossless === false) {
return true;
} else {
return false;
}
}

@ryo-manba ryo-manba changed the title chore: correct default value comments in Options interface chore: fix default value comments in Options interface Oct 26, 2024
@ryo-manba ryo-manba changed the title chore: fix default value comments in Options interface fix: typo Oct 28, 2024
@alexander-akait alexander-akait merged commit 56d7fea into postcss:master Oct 30, 2024
3 checks passed
@ryo-manba ryo-manba deleted the fix/option-comments branch October 30, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants