add sourceIndex to Selector nodes
#290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romainmenke
commented
May 11, 2024
| @@ -685,7 +693,10 @@ export default class Parser { | |||
| let unbalanced = 1; | |||
| this.position ++; | |||
| if (last && last.type === types.PSEUDO) { | |||
| const selector = new Selector({source: {start: tokenStart(this.tokens[this.position - 1])}}); | |||
There was a problem hiding this comment.
As far as I can tell this was always incorrect.
this.tokens[this.position - 1] is the open parenthesis, but that isn't the start token of the selector. The selector starts inside the parenthesis.
:is(foo)
^ here
:is(foo)
^ not here
By comparison when the selector is part of a list and follows a comma it also does not have the comma as the start position. It starts after the comma.
:is(foo,bar)
^ here
:is(foo,bar)
^ not here
alexander-akait
approved these changes
May 22, 2024
romainmenke
deleted the
add-source-index-to-selector-nodes--courteous-echidna-efbdb3ba14
branch
|
Thank you @alexander-akait 🙇 |
This was referenced Sep 7, 2024
This was referenced Sep 12, 2024
This was referenced Sep 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes : #287