Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.0.0+ breaks ember-css-modules #140

Closed
emattias opened this issue Oct 27, 2021 · 3 comments
Closed

5.0.0+ breaks ember-css-modules #140

emattias opened this issue Oct 27, 2021 · 3 comments

Comments

@emattias
Copy link

When using [email protected] (latest v4) together with ember-css-modules the classes get generated differently than when using [email protected] (latest v5).

See this issue for more info and reproduction repos: salsify/ember-css-modules#253

@ai
Copy link
Member

ai commented Oct 27, 2021

Yeap. [email protected] was started using new official PostCSS API (visitor API).

ember-css-modules should update a little to be ready for that because visitor API is a new way to use plugins.

If you know any specific things which can make ember-css-modules integration better, open another issue.

@emattias
Copy link
Author

@ai What do you think about what @dfreeman says here: salsify/ember-css-modules#253 (comment) ?

@ai
Copy link
Member

ai commented Nov 22, 2021

Yeap, the Once plugins is a very fast way to convert PostCSS plugin, but it doesn’t help with plugin compatibility.

The idea is to move to true event system with Rule, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants