Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skeletal Adapters #110

Open
hemeac opened this issue Aug 26, 2020 · 5 comments
Open

Skeletal Adapters #110

hemeac opened this issue Aug 26, 2020 · 5 comments
Assignees

Comments

@hemeac
Copy link

hemeac commented Aug 26, 2020

Having the 7-5 (nflv-skeletal-adapter-75-5-1.cfg) and 5-3.75 (nflv-skeletal-adapter-5-375-1.cfg) skeletal adapters default to empty creates an issue where the maximum capacity is removed, but the fuel as defined in the original config file remains. This issue fixes itself if you switch meshes, but an unsuspecting user may wonder why adding the truss adds 60 tons to their vessel. I think the quick solution may be to declare the Tanks subtype as the defaultSubtypePriority.

@hemeac
Copy link
Author

hemeac commented Aug 26, 2020


This may be more helpful

@hemeac
Copy link
Author

hemeac commented Sep 1, 2020

Should note that this is not an issue with Cryotanks installed, so may only affect a small subset of users who don't use the full suite of NF parts.

@ChrisAdderley
Copy link
Collaborator

That is weird, I'll look into it.

@hemeac
Copy link
Author

hemeac commented Sep 1, 2020

My guess is that in the part config you define fuel resources, but the B9PS defaults to the structure-only. That is different than how you approached the Mark IV fuselage parts in which you defined the basevolume in the B9 config, but did not define any fuel resources in the main part. Think the reason that Cryotanks fixes the issue is that the TankSwitcher config goes through and deletes all the original resources.

@ChrisAdderley
Copy link
Collaborator

Still need to investigate and sort this out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants