Skip to content

bugfix/button left right icon comment #87

Merged
merged 25 commits into from
Jan 30, 2019
Merged

bugfix/button left right icon comment #87

merged 25 commits into from
Jan 30, 2019

Conversation

roll314
Copy link
Contributor

@roll314 roll314 commented Jan 28, 2019 •
edited
Loading

данный код вызовет ошибочное добавление css классов mc-icon_left и mc-icon_right

<button mc-icon-button type="button">
    <!-- comment-before -->
    <i mc-icon="mc-angle-down-L_16"></i>
    <!-- comment-after -->
</button>

Peter Kornuishin added 25 commits July 4, 2018 19:18
feat(navbar): collapse optimisation
3f987a8
feat(navbar): collapse optimisation
39509ee
Merge remote-tracking branch 'upstream/master'
8b76c18 
# Conflicts:
#	src/lib-dev/navbar/styles.scss
#	src/lib/core/utils/utils.ts
#	src/lib/navbar/_navbar-base.scss
#	src/lib/navbar/navbar.component.ts
Merge remote-tracking branch 'upstream/master'
a1cb50e
Merge remote-tracking branch 'upstream/master'
3120ba9
Merge remote-tracking branch 'upstream/master'
f5369de
Merge remote-tracking branch 'upstream/master'
a021f53
Merge remote-tracking branch 'upstream/master'
e315e9c
Merge remote-tracking branch 'upstream/master'
6835162
Merge branch 'master' of https://github.com/positive-js/mosaic
aaa33f7
feat(textarea): added textarea
ea521eb
test added
4133e01
example fix
5e6a69d
build fix
cd127c5
karma config changed
8f276e6
review comments fix
aa9b588
Merge branch 'master' of https://github.com/positive-js/mosaic
00073da
resize fix
1adc00d
removed unnecessary method
d75cb39
feat(textarea): added public api
b141486
Merge branch 'master' of https://github.com/positive-js/mosaic
17c8f38
Merge branches 'feature/textarea' and 'master' of https://github.com/…
45fb968 
…roll314/mosaic
Merge branch 'master' of https://github.com/positive-js/mosaic
cc74ce1
Merge branch 'master' of https://github.com/positive-js/mosaic
cc73132
mc-icon-button fix for case when next sibling node is comment
621953b
@roll314 roll314 mentioned this pull request Jan 28, 2019
Merged
@lskramarov
Copy link
Contributor

  1. Откатил все сделанные изменения.
  2. добавил пример
    image
  3. у mc-icon нет классов mc-icon_left и mc-icon_right
    image

что я делаю не так ?

@roll314
Copy link
Contributor Author

roll314 commented Jan 30, 2019

  1. Откатил все сделанные изменения.
  2. добавил пример
    image
  3. у mc-icon нет классов mc-icon_left и mc-icon_right
    image

что я делаю не так ?

в твоем коде компилятор\транслятор\транспиялтор)) вырезал коменты, но коменты может добавить ангуляр например для *ngIf. Для получения такого комента надо добавить что то типа

<button mc-icon-button type="button">
    <div *ngIf="false"></div>
    <i mc-icon="mc-angle-down-L_16"></i>
</button>

lskramarov
lskramarov approved these changes Jan 30, 2019
View reviewed changes
Copy link
Contributor

@lskramarov lskramarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

так ок.

@pimenovoleg pimenovoleg merged commit d25d425 into positive-js:master Jan 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lskramarov lskramarov lskramarov approved these changes

@pimenovoleg pimenovoleg pimenovoleg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@roll314 @lskramarov @pimenovoleg