fix(cdk): add cdk-*-focused classes to radio and disable focus on alert #94 #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fork update
fix(cdk): fixing alert's and radio's focus FocusManager was added to radio component, and alert's close button's focus was disabled Breaking Changes: none
|
На вид все хорошо |
mikeozornin
approved these changes
Jul 18, 2019
lskramarov
reviewed
Jul 19, 2019
fix(radio): code refactoring code refactoring Breaking Changes: none
|
Готово! |
lskramarov
approved these changes
Jul 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
В компонент radio был добавлен FocusMonitor и отключен фокус при клике мыши. В alert не думаю, что есть смысл добавлять FocusMonitor для кнопки - попробовала установить фокус клавиатурой на реальном alert с
position: absolute;- не сработало. Пока просто отключила фокус на кнопке закрыть. @mikeozornin, посмотришь?