Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show a reasonable error in the HTML when the Shinylive JS Service Worker fails to load #171

Open
georgestagg opened this issue Aug 16, 2024 · 1 comment

Comments

@georgestagg
Copy link
Collaborator

georgestagg commented Aug 16, 2024

In at least some situations the above simply causes a white blank screen. We should detect and throw a visible error when:

  • Shinylive is not running under a web server, and so...
  • The Service Worker fails to load.

With some reasonable text to explain what has happened.

@gadenbuie
Copy link
Contributor

Another scenario to try to detect: when the service worker fails to load because recent updates to shinylive require a reload. In these cases, it's worth giving any kind of hint that reloading the page (or clearing the cache and reloading) is worth trying; these are otherwise quite confusing error messages. (Especially on https://shinylive.io.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants