Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSConnectExecutor.server_settings throws error if self.client is a PositClient object #547

Open
wch opened this issue Feb 25, 2024 · 0 comments

Comments

@wch
Copy link
Collaborator

wch commented Feb 25, 2024

With a RSConnectExecutor object, if .server_settings is accessed and self.client is a PositClient object (as opposed to a RSConnectClient object), it will throw an error.

I'm running into this problem while working on #545, when I try to deploy a Shiny app to shinyapps.io.

The problem is that the server_settings property accesses self.client.server_settings. self.client can be a RSConnectClient or PositClient object. However, the PositClient class does not have .server_settings.

https://github.com/rstudio/rsconnect-python/blob/34c77ea280c353ebdc8f2987f31765736aa6f96f/rsconnect/api.py#L916-L919

Maybe the PositClient class could have a .server_settings field, set to None or an empty dictionary?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant