Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't start runtimes that were never used #5992

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

jmcphers
Copy link
Collaborator

This change cause Positron to "forget" runtimes that are affiliated with the workspace but that aren't actually used, with the goal of preventing unwanted sessions from starting.

Some details:

  • A runtime is considered to be unused if it was auto-started as an affiliated runtime but then never actually used in the last session.
  • The runtime affiliation is not wholly removed; we just stop auto-starting it when Positron starts. So e.g. it is still consulted when auto-starting a console in order to run code.
  • This only applies to projects with multiple runtime affiliations. If you only have one runtime affiliated, it will auto-start even if you didn't use it in your last session.

Addresses #3432.

Release Notes

New Features

Bug Fixes

  • N/A

QA Notes

For the purposes of this feature, a runtime is considered to have been "used" if you switch to it in the Console.

@jmcphers jmcphers requested a review from timtmok January 14, 2025 19:24
Copy link

E2E Tests 🚀  ?
This PR will run tests tagged with: @critical

Copy link
Contributor

@timtmok timtmok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmcphers jmcphers merged commit 6dc5cc4 into main Jan 14, 2025
8 checks passed
@jmcphers jmcphers deleted the feature/forget-unused-runtimes branch January 14, 2025 23:11
@github-actions github-actions bot locked and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants