Fix changing cell type from python #5950
Conversation
|
E2E Tests 🚀 ? |
|
|
||
| positron_did_close_diagnostics(server, params) | ||
|
|
||
| # Wait for the diagnostics to be published |
There was a problem hiding this comment.
I was hesitant to add such a slow test (~1 second). Might be worth making the debounce behavior configurable and setting it to zero during tests.
There was a problem hiding this comment.
Also worth considering whether we actually want diagnostics to be debounced?
That was inherited from upstream (pappasam/jedi-language-server#241) but I'm not sure which is a better UX.
There was a problem hiding this comment.
making the debounce behavior configurable and setting it to zero during tests
Yeah, maybe this is a good idea, or at least something like 100ms so we know there is some debouncing?
whether we actually want diagnostics to be debounced
I like a bit of debouncing. Maybe 1s is too much though. Probably depends widely on the user but maybe 0.5s is okay?
There was a problem hiding this comment.
Cool, I've sped up the tests.
0.5 and 1s feel close enough that I think we can leave it as is for now and see if we get any user feedback / strong opinions.
Release Notes
New Features
Bug Fixes
QA Notes
See #4160 for the repro.