Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ark: No description shown for data frames or lists #638

Closed
jmcphers opened this issue May 26, 2023 · 2 comments
Closed

ark: No description shown for data frames or lists #638

jmcphers opened this issue May 26, 2023 · 2 comments
Labels
Milestone

Comments

@jmcphers
Copy link
Collaborator

jmcphers commented May 26, 2023

In the Python extension, the Environment implementation shows some information about data frames in the description field; here it's [3 rows x 2 columns] pandas.core.frame.DataFrame:

image

It also shows a summary for a list:

image

The R extension does not generate a description for either of these objects; the description is blank for data frames:

image

and lists:

image

I think we should show a short summary or description of these items. It's useful to be able to see something before they are expanded, especially if the environment pane becomes narrow enough to cause the type hint to become hidden. This makes the object look empty:

image
@DavisVaughan
Copy link
Contributor

@romainfrancois this looks reasonable to me. I'm not sure if you want to do more here right now so I'll let you close when you are ready, but consider this QC'd in its current state

One thing to note - For objects with multiple class names, in rlang:::obj_type_friendly() we have recently switched to only showing the first class name because I think that is more useful 99% of the time (note the tibble preview below). So that is something we could consider doing here too. r-lib/rlang#1622

Screen.Recording.2023-06-01.at.1.41.32.PM.mov
Screen Shot 2023-06-01 at 1 43 06 PM

@jmcphers
Copy link
Collaborator Author

I think we can consider this closed for alpha. Thanks @romainfrancois & @DavisVaughan!

@wesm wesm added the lang: r label Feb 29, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

4 participants