Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ark: Quick restarts after typing can trigger an LSP error #1150

Closed
DavisVaughan opened this issue Aug 24, 2023 · 2 comments
Closed

ark: Quick restarts after typing can trigger an LSP error #1150

DavisVaughan opened this issue Aug 24, 2023 · 2 comments
Labels
Milestone

Comments

@DavisVaughan
Copy link
Contributor

DavisVaughan commented Aug 24, 2023

In a release build of Positron (234, at the time of writing) try:

  • Type something in the Console
  • Immediately restart R with CMD+SHIFT+0

I often end up with this LSP error

Screen.Recording.2023-08-24.at.5.01.44.PM.mov

I can also reproduce when typing in a document and then quickly restarting (but not quite as reliably)

I would guess what happens is something like:

  • We make a document / console change, diagnostics are enqueued with a delay of 1 second
  • During that 1 second, we restart R, nuking something that the LSP would need to use
  • The 1 second is up, so the LSP tries to run the enqueued diagnostics, but whatever it needed is no longer available

I am not sure why I can't easily reproduce in a dev build right now (maybe something was fixed today?)

@DavisVaughan DavisVaughan added this to the Private Alpha milestone Aug 24, 2023
@jmcphers
Copy link
Collaborator

I think this might have been fixed by #1144.

@DavisVaughan
Copy link
Contributor Author

Oh yes in particular Lionel also reported this in this comment #1038 (comment)

@wesm wesm added the lang: r label Feb 29, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants