From 4d64ff024fc6fe2e10dddc58035114bc5b4d09a1 Mon Sep 17 00:00:00 2001 From: sharon wang Date: Thu, 10 Oct 2024 14:52:06 -0400 Subject: [PATCH] catch possible errors from starting the proxy or finishing proxy setup --- extensions/positron-proxy/src/positronProxy.ts | 18 ++++++++++++++---- 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/extensions/positron-proxy/src/positronProxy.ts b/extensions/positron-proxy/src/positronProxy.ts index 60137630011..18b90b4cfcd 100644 --- a/extensions/positron-proxy/src/positronProxy.ts +++ b/extensions/positron-proxy/src/positronProxy.ts @@ -334,11 +334,21 @@ export class PositronProxy implements Disposable { } // We don't have an existing proxy server for the target origin, so start a new one. - this.startNewProxyServer(contentRewriter).then(({ externalUri, finishProxySetup }) => { - finishProxySetup(targetOrigin).then(() => { - resolve(externalUri.toString()); + this.startNewProxyServer(contentRewriter) + .then(({ externalUri, finishProxySetup }) => { + finishProxySetup(targetOrigin) + .then(() => { + resolve(externalUri.toString()); + }) + .catch(error => { + console.error(`Failed to finish setting up the proxy server at ${externalUri} for target: ${targetOrigin}.`); + reject(error); + }); + }) + .catch(error => { + console.error(`Failed to start the proxy server for ${targetOrigin}.`); + reject(error); }); - }); }); }